Differential D13009

[avalanche] Processor event loop: make sure we test what we expect
ClosedPublic
Actions

Authored by Fabien on Jan 19 2023, 14:46.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC39cb578201e3: [avalanche] Processor event loop: make sure we test what we expect

Summary

There is a missing check in the vote registration; if it fails that will make the following query time check totally irrelevant.

Test Plan

ninja check-avalanche-processor_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_processor_check_register_votes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21794
Build 43223: Build Diff	build-clang-tidy · build-diff · lint-circular-dependencies · build-debug · build-without-wallet · build-clang
Build 43222: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 19 2023, 14:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2023, 14:46

Fabien requested review of this revision.Jan 19 2023, 14:46

Harbormaster completed remote builds in B21794: Diff 37597.Jan 19 2023, 14:59

Fabien added a child revision: D13013: [avalanche] Build the processor from the node context.Jan 19 2023, 16:15

PiRK accepted this revision.Jan 20 2023, 07:06

This revision is now accepted and ready to land.Jan 20 2023, 07:06

Closed by commit rABC39cb578201e3: [avalanche] Processor event loop: make sure we test what we expect (authored by Fabien). · Explain WhyJan 20 2023, 14:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC39cb578201e3: [avalanche] Processor event loop: make sure we test what we expect.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

3 lines

Diff 37597

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Processor event loop: make sure we test what we expectClosedPublicActions