Page MenuHomePhabricator
Differential D13023

Add and use CBlockIndexHeightOnlyComparator
ClosedPublic
Actions

Authored by PiRK on Jan 23 2023, 10:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2aa2529f4a7c: Add and use CBlockIndexHeightOnlyComparator
Summary

...also use std::sort for clarity

Add also a simple unit test for coverage.

This is a partial backport of core#24515
https://github.com/bitcoin/bitcoin/pull/24515/commits/28ba0313eac37e4a900b7e97af7169ce999c4024

Depends on D13022

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 23 2023, 10:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 10:16
PiRK requested review of this revision.Jan 23 2023, 10:16
teamcity edited the summary of this revision. (Show Details)Jan 23 2023, 10:16
PiRK added a child revision: D13024: Add and use BlockManager::GetAllBlockIndices.Jan 23 2023, 10:17
Harbormaster completed remote builds in B21813: Diff 37632.Jan 23 2023, 10:39
Fabien requested changes to this revision.Jan 23 2023, 14:19
Fabien added a subscriber: Fabien.

One nit, otherwise LGTM

src/test/blockindex_comparator_tests.cpp
70 ↗(On Diff #37632)

Please check also when reverting the parameters

This revision now requires changes to proceed.Jan 23 2023, 14:19
PiRK mentioned this in D13022: Only load BlockMan in BlockMan member functions.Jan 23 2023, 15:30
PiRK updated this revision to Diff 37635.Jan 23 2023, 15:33

review (add a test)

Fabien accepted this revision.Jan 23 2023, 15:43
This revision is now accepted and ready to land.Jan 23 2023, 15:43
Harbormaster completed remote builds in B21816: Diff 37635.Jan 23 2023, 15:47
Closed by commit rABC2aa2529f4a7c: Add and use CBlockIndexHeightOnlyComparator (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 23 2023, 15:48
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC3d50222404e8: Only load BlockMan in BlockMan member functions.
PiRK added a commit: rABC2aa2529f4a7c: Add and use CBlockIndexHeightOnlyComparator.

Revision Contents
Changeset List

PathSize
src/
avalanche/
2 lines
blockindexcomparators.h
blockindexworkcomparator.h
15 lines
node/
9 lines
test/
2 lines
blockindex_comparator_tests.cpp
work_comparator_tests.cpp
23 lines
2 lines
6 lines

Diff 37639

View Options

src/avalanche/processor.h

Loading...
View Options

src/blockindexcomparators.h

Loading...
View Options

src/blockindexworkcomparator.h

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/blockindex_comparator_tests.cpp

Loading...
View Options

src/test/work_comparator_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...