Page MenuHomePhabricator
Differential D13022

Only load BlockMan in BlockMan member functions
ClosedPublic
Actions

Authored by PiRK on Jan 23 2023, 10:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3d50222404e8: Only load BlockMan in BlockMan member functions
Summary

This commit effectively splits the "load block index itself" logic from
"derive Chainstate variables from loaded block index" logic.

This means that BlockManager::LoadBlockIndex{,DB} will only load what's
relevant to the BlockManager.

I strongly recommend reviewing with the following git-diff flags:

--color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change

This is a partial backport of core#24515
https://github.com/bitcoin/bitcoin/pull/24515/commits/c600ee38168a460d3026eae0e289c976194aad14

Depends on D13021

The sorting code is deduplicated in D13023

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 23 2023, 10:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 10:14
PiRK requested review of this revision.Jan 23 2023, 10:14
teamcity edited the summary of this revision. (Show Details)Jan 23 2023, 10:14
PiRK added a child revision: D13023: Add and use CBlockIndexHeightOnlyComparator.Jan 23 2023, 10:16
Harbormaster completed remote builds in B21812: Diff 37631.Jan 23 2023, 10:40
Fabien requested changes to this revision.Jan 23 2023, 14:15
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
5011 ↗(On Diff #37631)

This is duplicated code

This revision now requires changes to proceed.Jan 23 2023, 14:15
Fabien accepted this revision.Jan 23 2023, 14:21

This is deduplicated in the next diffs, you really need to add this info to the summary to prevent these back and forth reviews

This revision is now accepted and ready to land.Jan 23 2023, 14:21
PiRK edited the summary of this revision. (Show Details)Jan 23 2023, 15:30
PiRK edited the test plan for this revision. (Show Details)
Closed by commit rABC3d50222404e8: Only load BlockMan in BlockMan member functions (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 23 2023, 15:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3d50222404e8: Only load BlockMan in BlockMan member functions.

Revision Contents
Changeset List

PathSize
src/
node/
6 lines
81 lines
3 lines
94 lines

Diff 37638

View Options

src/node/blockstorage.h

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...