Page MenuHomePhabricator

[avalanche] Fix a wrong test in abc_rpc_avalancheproof
ClosedPublic

Authored by Fabien on Jan 23 2023, 20:02.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC6c5f09efeba5: [avalanche] Fix a wrong test in abc_rpc_avalancheproof
Summary

Make sure we are testing what we expect, i.e. node 1 (and not 0) turns the proof mature (which wait_for_proof doesn't do as it asserts as soon as the proof is found).

Test Plan
./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 23 2023, 20:02

Also fix the following wait_for_proof, which is wrong as the proof is already known and what we want is to check it turns mature.

sdulfari requested changes to this revision.Jan 23 2023, 22:03
sdulfari added a subscriber: sdulfari.

Diff title needs rewriting now that there isn't a typo being fixed

This revision now requires changes to proceed.Jan 23 2023, 22:03

It still fixes the typo, which I reintroduced...

Fabien retitled this revision from [avalanche] Fix a typo in the abc_rpc_avalancheproof test to [avalanche] Fix a wrong test in abc_rpc_avalancheproof.Jan 24 2023, 09:07
Fabien edited the summary of this revision. (Show Details)

Update title and summary, undo the typo fix reversal.

This revision is now accepted and ready to land.Jan 24 2023, 16:26