Page MenuHomePhabricator
Differential D13030

[avalanche] Delay the local proof announcement until we have inbounds
ClosedPublic
Actions

Authored by Fabien on Jan 23 2023, 21:17.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC34eb66eb5a30: [avalanche] Delay the local proof announcement until we have inbounds
Summary

This is a best effort to prevent from spinning a voting peer that takes no inbound, and possibly being poorly connected to the avalanche network (it is impossible to connect 2 peers that accept no inbound connection).

Depends on D13027, D13028 and D13029.

Test Plan
ninja check-extended
../contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 23 2023, 21:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 21:17
Fabien requested review of this revision.Jan 23 2023, 21:17
Harbormaster completed remote builds in B21823: Diff 37647.Jan 23 2023, 21:31
sdulfari requested changes to this revision.Jan 23 2023, 22:35
sdulfari added a subscriber: sdulfari.

Normally wouldn't block on a comment, but the added inbound is not obvious reading the tests by themselves.

test/functional/abc_feature_proof_cleanup.py
52 ↗(On Diff #37647)

Comment that this is adding an inbound, otherwise it appears useless on the surface

test/functional/abc_p2p_avalanche_peer_discovery.py
243 ↗(On Diff #37647)

same here. considering doing it everywhere in this diff where it's needed

This revision now requires changes to proceed.Jan 23 2023, 22:35
Fabien updated this revision to Diff 37686.Jan 24 2023, 13:01

Consistently add comments

Harbormaster completed remote builds in B21848: Diff 37686.Jan 24 2023, 13:20
Fabien updated this revision to Diff 37694.Jan 24 2023, 14:00

Reword release notes

Harbormaster completed remote builds in B21850: Diff 37694.Jan 24 2023, 14:14
Fabien added a child revision: D13050: [avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is shared.Jan 24 2023, 14:26
sdulfari accepted this revision.Jan 24 2023, 16:28
sdulfari added inline comments.
doc/release-notes.md
8 ↗(On Diff #37694)
This revision is now accepted and ready to land.Jan 24 2023, 16:28
Closed by commit rABC34eb66eb5a30: [avalanche] Delay the local proof announcement until we have inbounds (authored by Fabien). · Explain WhyJan 24 2023, 17:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC34eb66eb5a30: [avalanche] Delay the local proof announcement until we have inbounds.

Revision Contents
Changeset List

Diff 37707

View Options

doc/release-notes.md

Loading...
View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_feature_proof_cleanup.py

Loading...
View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...
View Options

test/functional/abc_rpc_getavalancheinfo.py

Loading...
View Options

test/functional/abc_rpc_getavalancheproofs.py

Loading...
View Options

test/functional/p2p_inv_download.py

Loading...