Page MenuHomePhabricator

[avalanche] Delay the local proof announcement until we have inbounds
ClosedPublic

Authored by Fabien on Jan 23 2023, 21:17.

Details

Summary

This is a best effort to prevent from spinning a voting peer that takes no inbound, and possibly being poorly connected to the avalanche network (it is impossible to connect 2 peers that accept no inbound connection).

Depends on D13027, D13028 and D13029.

Test Plan
ninja check-extended
../contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 23 2023, 21:17
sdulfari requested changes to this revision.Jan 23 2023, 22:35
sdulfari added a subscriber: sdulfari.

Normally wouldn't block on a comment, but the added inbound is not obvious reading the tests by themselves.

test/functional/abc_feature_proof_cleanup.py
52 ↗(On Diff #37647)

Comment that this is adding an inbound, otherwise it appears useless on the surface

test/functional/abc_p2p_avalanche_peer_discovery.py
243 ↗(On Diff #37647)

same here. considering doing it everywhere in this diff where it's needed

This revision now requires changes to proceed.Jan 23 2023, 22:35

Consistently add comments

sdulfari added inline comments.
doc/release-notes.md
8 ↗(On Diff #37694)
This revision is now accepted and ready to land.Jan 24 2023, 16:28