Differential D13030

[avalanche] Delay the local proof announcement until we have inbounds
ClosedPublic
Actions

Authored by Fabien on Jan 23 2023, 21:17.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC34eb66eb5a30: [avalanche] Delay the local proof announcement until we have inbounds

Summary

This is a best effort to prevent from spinning a voting peer that takes no inbound, and possibly being poorly connected to the avalanche network (it is impossible to connect 2 peers that accept no inbound connection).

Depends on D13027, D13028 and D13029.

Test Plan

ninja check-extended
../contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_delay_proof_inbound

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21850
Build 43335: Build Diff	lint-circular-dependencies · build-debug · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 43334: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2023, 21:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 21:17

Fabien requested review of this revision.Jan 23 2023, 21:17

Harbormaster completed remote builds in B21823: Diff 37647.Jan 23 2023, 21:31

Normally wouldn't block on a comment, but the added inbound is not obvious reading the tests by themselves.

test/functional/abc_feature_proof_cleanup.py
52 ↗	(On Diff #37647)	Comment that this is adding an inbound, otherwise it appears useless on the surface
test/functional/abc_p2p_avalanche_peer_discovery.py
243 ↗	(On Diff #37647)	same here. considering doing it everywhere in this diff where it's needed