Differential D13028

[avalanche] Fix a wrong test in abc_rpc_avalancheproof
ClosedPublic
Actions

Authored by Fabien on Jan 23 2023, 20:02.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC6c5f09efeba5: [avalanche] Fix a wrong test in abc_rpc_avalancheproof

Summary

Make sure we are testing what we expect, i.e. node 1 (and not 0) turns the proof mature (which wait_for_proof doesn't do as it asserts as soon as the proof is found).

Test Plan

./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_fix_rpc_avalancheproof_typo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21832
Build 43299: Build Diff	build-diff · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 43298: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2023, 20:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 20:02

Fabien requested review of this revision.Jan 23 2023, 20:02

Harbormaster completed remote builds in B21819: Diff 37643.Jan 23 2023, 20:15

Also fix the following wait_for_proof, which is wrong as the proof is already known and what we want is to check it turns mature.

Fabien added a child revision: D13030: [avalanche] Delay the local proof announcement until we have inbounds.Jan 23 2023, 21:17

Harbormaster completed remote builds in B21822: Diff 37646.Jan 23 2023, 21:27

Diff title needs rewriting now that there isn't a typo being fixed

This revision now requires changes to proceed.Jan 23 2023, 22:03

It still fixes the typo, which I reintroduced...

Fabien retitled this revision from [avalanche] Fix a typo in the abc_rpc_avalancheproof test to [avalanche] Fix a wrong test in abc_rpc_avalancheproof.Jan 24 2023, 09:07

Fabien edited the summary of this revision. (Show Details)

Update title and summary, undo the typo fix reversal.

Harbormaster completed remote builds in B21832: Diff 37658.Jan 24 2023, 09:25

sdulfari accepted this revision.Jan 24 2023, 16:26

This revision is now accepted and ready to land.Jan 24 2023, 16:26

Closed by commit rABC6c5f09efeba5: [avalanche] Fix a wrong test in abc_rpc_avalancheproof (authored by Fabien). · Explain WhyJan 24 2023, 17:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6c5f09efeba5: [avalanche] Fix a wrong test in abc_rpc_avalancheproof.