Clear pindexBestHeader in ChainstateManager::Unload()
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 12:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC75289e8ea88a: Clear pindexBestHeader in ChainstateManager::Unload()

Summary

Code Reviewer Notes

Call graph of relevant functions:

UnloadBlockIndex() <-- Moved from
calls ChainstateManager::Unload() <-- Moved to

Safe because ChainstateManager::Unload() is called only by
UnloadBlockIndex() and no other callers.

This is a partial backport of core#24909
https://github.com/bitcoin/bitcoin/pull/24909/commits/c96524113c48553c4bbad63077a25494eca8159e

Depends on D13044

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 24 2023, 12:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 12:03

PiRK requested review of this revision.Jan 24 2023, 12:03

teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 12:03

PiRK added a child revision: D13046: move-mostly: Make fHavePruned a BlockMan member.Jan 24 2023, 12:05

Harbormaster completed remote builds in B21842: Diff 37678.Jan 24 2023, 12:22

Fabien accepted this revision.Jan 24 2023, 12:51

This revision is now accepted and ready to land.Jan 24 2023, 12:51

Closed by commit rABC75289e8ea88a: Clear pindexBestHeader in ChainstateManager::Unload() (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 24 2023, 13:29

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC75289e8ea88a: Clear pindexBestHeader in ChainstateManager::Unload().

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

2 lines

Diff 37689

View Options

Clear pindexBestHeader in ChainstateManager::Unload()ClosedPublicActions