Page MenuHomePhabricator
Differential D13050

[avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is shared
ClosedPublic
Actions

Authored by Fabien on Jan 24 2023, 14:26.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC964a64e6311a: [avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is…
Summary

Since D13030 the node is waiting for an inbound connection before it can share the local proof with the avalanche network. This diff adds a new field to the getavalancheinfo RPC to monitor this status.

Depends on D13030.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_rpc_ready_to_vote
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21851
Build 43337: Build Diffbuild-debug · build-clang · lint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy
Build 43336: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2023, 14:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 14:26
Fabien requested review of this revision.Jan 24 2023, 14:26
Harbormaster completed remote builds in B21851: Diff 37695.Jan 24 2023, 14:38
sdulfari accepted this revision.Jan 24 2023, 16:32
sdulfari added a subscriber: sdulfari.

Patch is good. I will leave final call on the naming to you.

src/rpc/avalanche.cpp
661

is_sharing or is_advertising make more sense to me. ready_to_share is not clear if it is currently sharing or just able to.

This revision is now accepted and ready to land.Jan 24 2023, 16:32
Fabien updated this revision to Diff 37708.Jan 24 2023, 17:21

Update the name

sdulfari accepted this revision.Jan 24 2023, 17:25
Harbormaster completed remote builds in B21860: Diff 37708.Jan 24 2023, 17:58
Closed by commit rABC964a64e6311a: [avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is… (authored by Fabien). · Explain WhyJan 24 2023, 18:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC964a64e6311a: [avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is….

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
5 lines
test/
functional/
68 lines

Diff 37695

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_getavalancheinfo.py

Loading...