Differential D13058

Remove 10-block rolling finalization
ClosedPublic
Actions

Authored by sdulfari on Jan 24 2023, 18:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC19c9d75cfd10: Remove 10-block rolling finalization

Summary

Now that Avalanche is enabled by default the 10-block rolling finalization is safe to remove.

Removing this now will make adding Avalanche block policies easier and lower risk.

Depends on D13063

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rm-finalization

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21861
Build 43357: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43356: arc lint + arc unit

Event Timeline

sdulfari created this revision.Jan 24 2023, 18:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 18:00

sdulfari requested review of this revision.Jan 24 2023, 18:00

Harbormaster completed remote builds in B21861: Diff 37709.Jan 24 2023, 18:29

Fabien added a subscriber: Fabien.Jan 25 2023, 10:32

Fabien added inline comments.

src/validation.cpp
1381	Could this be added and tested in an ancestor diff ?

Rebase on D13063

sdulfari edited the summary of this revision. (Show Details)Jan 25 2023, 18:41

sdulfari added a parent revision: D13063: [avalanche] Rewind Avalanche finalization if a finalized block is found to be invalid.

Harbormaster completed remote builds in B21873: Diff 37729.Jan 25 2023, 18:53

The release notes needs a rebase (see D13064) but otherwise LGTM

This revision is now accepted and ready to land.Jan 25 2023, 19:42

Rebase on D13064

Harbormaster completed remote builds in B21876: Diff 37736.Jan 25 2023, 23:24

Closed by commit rABC19c9d75cfd10: Remove 10-block rolling finalization (authored by sdulfari). · Explain WhyJan 26 2023, 16:55

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC19c9d75cfd10: Remove 10-block rolling finalization.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

4 lines

src/

avalanche/

processor.cpp

5 lines

init.cpp

12 lines

rpc/

blockchain.cpp

72 lines

test/

CMakeLists.txt

1 line

finalization_tests.cpp

validation.h

34 lines

validation.cpp

173 lines

test/

functional/

abc-finalize-block.py

abc-parkedchain.py

1 line

abc_p2p_avalanche_voting.py

1 line

feature_bip68_sequence.py

2 lines

feature_block.py

2 lines

feature_pruning.py

12 lines

test_runner.py

2 lines

Diff 37709

View Options

doc/release-notes.md

View Options

src/avalanche/processor.cpp

View Options

src/init.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/test/CMakeLists.txt

View Options

src/test/finalization_tests.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

test/functional/abc-finalize-block.py

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/test_runner.py

Remove 10-block rolling finalizationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37709

doc/release-notes.md

src/avalanche/processor.cpp

src/init.cpp

src/rpc/blockchain.cpp

src/test/CMakeLists.txt

src/test/finalization_tests.cpp

src/validation.h

src/validation.cpp

test/functional/abc-finalize-block.py

test/functional/abc-parkedchain.py

test/functional/abc_p2p_avalanche_voting.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_pruning.py

test/functional/test_runner.py

Remove 10-block rolling finalization
ClosedPublic
Actions

Revision Contents
Changeset List