Page MenuHomePhabricator
Differential D13081

[avalanche] initialize g_avalanche after loading the block chain
ClosedPublic
Actions

Authored by PiRK on Jan 31 2023, 16:02.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC5badc03b0de3: [avalanche] initialize g_avalanche after loading the block chain
Summary

Initializing Avalanche requires the ChainstateManager to be initialized first. In a next commit, when backporting https://github.com/bitcoin/bitcoin/pull/22564/commits/5921b863e39e5c3997895ffee1c87159e37a5d6f, the chainman will be initialized after the loading of the block chain.

As far as I can tell this is OK because at this point the Avalanche event loop is not yet started, and the other components don't use g_avalanche or nLocalServices at this point. These objects are both used when the node is started at step 12.

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jan 31 2023, 16:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2023, 16:02
PiRK requested review of this revision.Jan 31 2023, 16:02
PiRK edited the summary of this revision. (Show Details)Jan 31 2023, 16:05
PiRK retitled this revision from initialize avalanche after loading the block chain to [avalanche] initialize g_avalanche after loading the block chain.
Harbormaster completed remote builds in B21900: Diff 37768.Jan 31 2023, 16:16
sdulfari accepted this revision.Jan 31 2023, 17:41
sdulfari added a subscriber: sdulfari.

Please monitor IBD test logs for network related messages that indicate Avalanche is not initialized. I don't expect them but let's be sure about it.

This revision is now accepted and ready to land.Jan 31 2023, 17:41
PiRK added a child revision: D13087: init: Reset mempool and chainman via reconstruction.Feb 1 2023, 14:05
PiRK added a comment.Feb 1 2023, 16:04

Avalanche started successfully after the IBD.

Closed by commit rABC5badc03b0de3: [avalanche] initialize g_avalanche after loading the block chain (authored by PiRK). · Explain WhyFeb 2 2023, 11:30
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5badc03b0de3: [avalanche] initialize g_avalanche after loading the block chain.

Revision Contents
Changeset List

PathSize
src/
30 lines

Diff 37768

View Options

src/init.cpp

Loading...