Differential D13084

[alias-server] [p8] Complete getAliases function
ClosedPublic
Actions

Authored by bytesofman on Jan 31 2023, 23:55.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC9f91403cda3f: [alias-server] [p8] Complete getAliases function

Summary

T2922

Depends on D13080

Complete getAliases function, with unit test

Test Plan

node index.js and confirm output matches latest
npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alias-node-app

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21904
Build 43443: Build Diff
Build 43442: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 31 2023, 23:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2023, 23:55

bytesofman requested review of this revision.Jan 31 2023, 23:55

Harbormaster completed remote builds in B21904: Diff 37775.Jan 31 2023, 23:56

need to write unit test here

Updating mocks, tests, still incomplete

Harbormaster completed remote builds in B21913: Diff 37785.Feb 1 2023, 16:47

Still needs more thought in how mocks are organized, functions structured

Updating mocks and unit tests

Harbormaster completed remote builds in B21958: Diff 37851.Feb 8 2023, 00:21

bytesofman added a child revision: D13111: [alias-server] [p9] Refactor functions to accept constants as input params.Feb 8 2023, 14:53

There's a mismatch of fees between config.js and the onchain fees used by cashtab. In my stack anything over 8 chars is 551 sats.

This revision now requires changes to proceed.Feb 24 2023, 03:55

There's a mismatch of fees between config.js and the onchain fees used by cashtab. In my stack anything over 8 chars is 551 sats.

Saw this being rectified in part 12, greening this

This revision is now accepted and ready to land.Feb 24 2023, 04:55

Closed by commit rABC9f91403cda3f: [alias-server] [p8] Complete getAliases function (authored by bytesofman). · Explain WhyFeb 28 2023, 22:45

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC9f91403cda3f: [alias-server] [p8] Complete getAliases function.

Revision Contents
Changeset List

Path

Size

web/

alias-server/

alias.js

17 lines

index.js

3 lines

Diff 37775

View Options

web/alias-server/alias.js