Page MenuHomePhabricator
Differential D13084

[alias-server] [p8] Complete getAliases function
ClosedPublic
Actions

Authored by bytesofman on Jan 31 2023, 23:55.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC9f91403cda3f: [alias-server] [p8] Complete getAliases function
Summary

T2922

Depends on D13080

Complete getAliases function, with unit test

Test Plan

node index.js and confirm output matches latest
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-node-app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21913
Build 43461: Build Diff
Build 43460: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 31 2023, 23:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2023, 23:55
bytesofman requested review of this revision.Jan 31 2023, 23:55
Harbormaster completed remote builds in B21904: Diff 37775.Jan 31 2023, 23:56
bytesofman planned changes to this revision.Jan 31 2023, 23:56

need to write unit test here

bytesofman updated this revision to Diff 37785.Feb 1 2023, 16:47

Updating mocks, tests, still incomplete

Harbormaster completed remote builds in B21913: Diff 37785.Feb 1 2023, 16:47
bytesofman planned changes to this revision.Feb 1 2023, 16:47

Still needs more thought in how mocks are organized, functions structured

bytesofman updated this revision to Diff 37851.Feb 8 2023, 00:21

Updating mocks and unit tests

Harbormaster completed remote builds in B21958: Diff 37851.Feb 8 2023, 00:21
bytesofman added a child revision: D13111: [alias-server] [p9] Refactor functions to accept constants as input params.Feb 8 2023, 14:53
emack requested changes to this revision.Feb 24 2023, 03:55
emack added a subscriber: emack.

image.png (220×1 px, 63 KB)

There's a mismatch of fees between config.js and the onchain fees used by cashtab. In my stack anything over 8 chars is 551 sats.

This revision now requires changes to proceed.Feb 24 2023, 03:55
emack accepted this revision.Feb 24 2023, 04:55

There's a mismatch of fees between config.js and the onchain fees used by cashtab. In my stack anything over 8 chars is 551 sats.

Saw this being rectified in part 12, greening this

This revision is now accepted and ready to land.Feb 24 2023, 04:55
Closed by commit rABC9f91403cda3f: [alias-server] [p8] Complete getAliases function (authored by bytesofman). · Explain WhyFeb 28 2023, 22:45
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC9f91403cda3f: [alias-server] [p8] Complete getAliases function.

Revision Contents
Changeset List

PathSize
web/
alias-server/
1 line
22 lines
9 lines
test/
32 lines
mocks/
277 lines

Diff 37785

View Options

web/alias-server/README.md

Loading...
View Options

web/alias-server/alias.js

Loading...
View Options

web/alias-server/index.js

Loading...
View Options

web/alias-server/test/alias.js

Loading...
View Options

web/alias-server/test/mocks/aliasMocks.js

Loading...