Page MenuHomePhabricator

validation: Prune UnloadBlockIndex and callees
ClosedPublic

Authored by PiRK on Feb 1 2023, 15:57.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC9ba9cf2f6990: validation: Prune UnloadBlockIndex and callees
Summary

In previous commits in this patchset, we've made sure that every
Unload/UnloadBlockIndex member function resets its own members, and does
not reach out to globals.

This means that their corresponding classes' default destructors can now
replace them, and do an even more thorough job without the need to be
updated for every new member variable.

Therefore, we can remove them, and also remove UnloadBlockIndex since
that's not used anymore.

Unfortunately, chainstatemanager_loadblockindex relies on
CChainState::UnloadBlockIndex, so that needs to stay for now.

This concludes backport of core#22564
https://github.com/bitcoin/bitcoin/pull/22564/commits/7ab07e033237d6ea179a6a2c76575ed6bd01a670

Depends on D13091

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable