Paths

Table of Contentst

Differential D16069

Remove unused SetTip(nullptr) code
ClosedPublic
Actions

Authored by PiRK on Mon, Apr 29, 10:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbb8db084544e: Remove unused SetTip(nullptr) code

Summary

Now that this path is no longer used after D13092, we can remove it.

Future code should reset CChain by simply discarding it and constructing a fresh one.

This is a backport of core#25023

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Apr 29, 10:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 29, 10:53

PiRK requested review of this revision.Mon, Apr 29, 10:53

teamcity edited the summary of this revision. (Show Details)Mon, Apr 29, 10:53

PiRK added a child revision: D16070: CBlockIndex: ensure phashBlock is not nullptr before dereferencing.Mon, Apr 29, 11:15

Harbormaster completed remote builds in B28786: Diff 47470.Mon, Apr 29, 11:27

Fabien accepted this revision.Mon, Apr 29, 12:49

This revision is now accepted and ready to land.Mon, Apr 29, 12:49

Closed by commit rABCbb8db084544e: Remove unused SetTip(nullptr) code (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMon, Apr 29, 14:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbb8db084544e: Remove unused SetTip(nullptr) code.

Revision Contents
Changeset List

Path

Size

src/

chain.h

2 lines

chain.cpp

8 lines

test/

miner_tests.cpp

6 lines

skiplist_tests.cpp

6 lines

validation_block_tests.cpp

4 lines

validation.cpp

9 lines

Diff 47476

View Options

src/chain.h

View Options

src/chain.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

Remove unused SetTip(nullptr) codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47476

src/chain.h

src/chain.cpp

src/test/miner_tests.cpp

src/test/skiplist_tests.cpp

src/test/validation_block_tests.cpp

src/validation.cpp

Remove unused SetTip(nullptr) code
ClosedPublic
Actions

Revision Contents
Changeset List