Page MenuHomePhabricator
Differential D16073

refactor: move CBlockIndex#ToString() from header to implementation
ClosedPublic
Actions

Authored by PiRK on Apr 29 2024, 11:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf73333d93673: refactor: move CBlockIndex#ToString() from header to implementation
Summary

which allows dropping tinyformat.h from the header file.

This concludes backport of core#25349
https://github.com/bitcoin/bitcoin/pull/25349/commits/3a61fc56a0ad6ed58570350dcfd9ed2d10239b48

Depends on D16072

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 29 2024, 11:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2024, 11:21
PiRK requested review of this revision.Apr 29 2024, 11:21
teamcity edited the summary of this revision. (Show Details)Apr 29 2024, 11:21
Harbormaster completed remote builds in B28790: Diff 47474.Apr 29 2024, 12:17
Fabien resigned from this revision.Apr 29 2024, 13:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/chain.h
19 ↗(On Diff #47474)

unrelated ?

Fabien requested changes to this revision.Apr 29 2024, 13:01
This revision now requires changes to proceed.Apr 29 2024, 13:01
PiRK requested review of this revision.Apr 29 2024, 13:55
PiRK added inline comments.
src/chain.h
19 ↗(On Diff #47474)

It is semi-related imo. It should have been removed in D6988 when CBlockIndex was moved to its own module. It was probably initially there for CBlockIndex::ToString()

Fabien accepted this revision.Apr 29 2024, 15:51
This revision is now accepted and ready to land.Apr 29 2024, 15:51
Closed by commit rABCf73333d93673: refactor: move CBlockIndex#ToString() from header to implementation (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyApr 29 2024, 18:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf73333d93673: refactor: move CBlockIndex#ToString() from header to implementation.

Revision Contents
Changeset List

PathSize
src/
7 lines
7 lines
1 line

Diff 47487

View Options

src/blockindex.h

Loading...
View Options

src/blockindex.cpp

Loading...
View Options

src/chain.h

Loading...