Differential D16071

DiskBlockIndex: remove unused ToString() class member
ClosedPublic
Actions

Authored by PiRK on Apr 29 2024, 11:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC820b59d6c5f1: DiskBlockIndex: remove unused ToString() class member

Summary

and mark its inherited CBlockIndex#ToString public interface member
as deleted, to disallow calling it in the derived CDiskBlockIndex class.

This is a partial backport of core#25349
https://github.com/bitcoin/bitcoin/pull/25349/commits/99e8ec8721a52cd08bdca31f6e926c9c1ce281fb

Depends on D16070

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 29 2024, 11:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2024, 11:17

PiRK requested review of this revision.Apr 29 2024, 11:17

teamcity edited the summary of this revision. (Show Details)Apr 29 2024, 11:17

PiRK added a child revision: D16072: CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash().Apr 29 2024, 11:18

Harbormaster completed remote builds in B28788: Diff 47472.Apr 29 2024, 11:54

Fabien accepted this revision.Apr 29 2024, 12:54

This revision is now accepted and ready to land.Apr 29 2024, 12:54

Closed by commit rABC820b59d6c5f1: DiskBlockIndex: remove unused ToString() class member (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyApr 29 2024, 18:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC820b59d6c5f1: DiskBlockIndex: remove unused ToString() class member.

Revision Contents
Changeset List

Path

Size

src/

chain.h

8 lines

test/

fuzz/

chain.cpp

1 line

Diff 47485

View Options

src/chain.h