Page MenuHomePhabricator
Differential D13100

[tests] show the proofid when representing a proof
ClosedPublic
Actions

Authored by PiRK on Feb 2 2023, 17:33.

Details

Reviewers
sdulfari
Fabien
Group Reviewers
Restricted Project
Commits
rABC395893c395cf: [tests] show the proofid when representing a proof
Summary

This would have made it easier to debug the issue fixed by D13099, to verify that the received msg_avaproof was indeed the one corresponding to the sent msg_getdata before comparing the timestamps.

Test Plan

Make a test involving a msg_avaproof (e.g. abc_p2p_compactproofs) fail and inspect the log for a msg_avaproof.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 2 2023, 17:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2023, 17:33
PiRK requested review of this revision.Feb 2 2023, 17:33
Harbormaster completed remote builds in B21921: Diff 37800.Feb 2 2023, 17:51
sdulfari requested changes to this revision.Feb 2 2023, 19:33
sdulfari added a subscriber: sdulfari.

Include limited_proofid too

This revision now requires changes to proceed.Feb 2 2023, 19:33
PiRK updated this revision to Diff 37817.Feb 3 2023, 07:40

include also limited_proofid in repr

PiRK edited the test plan for this revision. (Show Details)Feb 3 2023, 07:41
Harbormaster completed remote builds in B21934: Diff 37817.Feb 3 2023, 08:28
Fabien requested changes to this revision.Feb 5 2023, 11:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/messages.py
954 ↗(On Diff #37817)

We now have uint256_hex in util.py

This revision now requires changes to proceed.Feb 5 2023, 11:59
PiRK updated this revision to Diff 37883.Feb 14 2023, 08:32

use uint256_hex

Fabien accepted this revision.Feb 14 2023, 08:49
Harbormaster completed remote builds in B21981: Diff 37883.Feb 14 2023, 08:54
sdulfari accepted this revision.Feb 14 2023, 22:17
This revision is now accepted and ready to land.Feb 14 2023, 22:17
Closed by commit rABC395893c395cf: [tests] show the proofid when representing a proof (authored by PiRK). · Explain WhyFeb 15 2023, 08:02
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC395893c395cf: [tests] show the proofid when representing a proof.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
4 lines

Diff 37891

View Options

test/functional/test_framework/messages.py

Loading...