Paths

Table of Contentst

Differential D13184

test: use f-strings in feature_* tests (part 1)
ClosedPublic
Actions

Authored by PiRK on Feb 28 2023, 07:33.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe42866581187: test: use f-strings in feature_* tests (part 1)

Summary

Also improve some strings containing escaped double-quotes by using single quotes (as per PEP8 recommendation https://peps.python.org/pep-0008/#string-quotes)

This is a partial backport of core#22229

https://github.com/bitcoin/bitcoin/pull/22229/commits/6f3d5ad67ac8e7b50abae1a2949898d858e38106
https://github.com/bitcoin/bitcoin/pull/22229/commits/dca173cc044270b30782b1e3355e9dcb8c534295
https://github.com/bitcoin/bitcoin/pull/22229/commits/36d33d32b1b498b61f56d552f6e2c1d064f978c3
https://github.com/bitcoin/bitcoin/pull/22229/commits/e2f1fd8ee92fa421b6d293169044d6ddd5a9b8df

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr22229

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22123
Build 43881: Build Diff	build-clang-tidy · build-without-wallet · build-debug · build-diff · build-clang
Build 43880: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 28 2023, 07:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2023, 07:33

PiRK requested review of this revision.Feb 28 2023, 07:33

teamcity edited the summary of this revision. (Show Details)Feb 28 2023, 07:33

Harbormaster completed remote builds in B22123: Diff 38087.Feb 28 2023, 07:48

Fabien accepted this revision.Feb 28 2023, 08:05

This revision is now accepted and ready to land.Feb 28 2023, 08:05

Closed by commit rABCe42866581187: test: use f-strings in feature_* tests (part 1) (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyFeb 28 2023, 09:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe42866581187: test: use f-strings in feature_* tests (part 1).

PiRK mentioned this in D13191: test: use f-strings in feature_* tests (part 3, with flynt).Feb 28 2023, 15:59

PiRK mentioned this in rABCe3d2ac1fd3e4: test: use f-strings in feature_* tests (part 3, with flynt).Mar 1 2023, 09:38

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_asmap.py

17 lines

feature_blocksdir.py

5 lines

feature_cltv.py

7 lines

feature_config_args.py

24 lines

Diff 38087

test/functional/feature_asmap.py

Loading...

test/functional/feature_blocksdir.py

Loading...

test/functional/feature_cltv.py

Loading...

test/functional/feature_config_args.py

Loading...