Paths

Table of Contentst

Differential D13191

test: use f-strings in feature_* tests (part 3, with flynt)
ClosedPublic
Actions

Authored by PiRK on Feb 28 2023, 15:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe3d2ac1fd3e4: test: use f-strings in feature_* tests (part 3, with flynt)

Summary

Inspired by core#22229 (see D13187 and D13184)

Scripted diff:

flynt test/functional/feature_* --transform-concats

Manual changes:

replace a "{1}" with "1"
remove explicit string conversion inside placeholders (f"{str(foo}" -> f"{foo}")

Depends on D13190

Test Plan

test/functional/test_runner.py feature_*

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22161
Build 43957: Build Diff	build-without-wallet · build-clang · build-diff · build-clang-tidy · build-debug
Build 43956: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 28 2023, 15:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2023, 15:59

PiRK requested review of this revision.Feb 28 2023, 15:59

teamcity edited the summary of this revision. (Show Details)Feb 28 2023, 15:59

PiRK edited the summary of this revision. (Show Details)Feb 28 2023, 16:00

PiRK added a parent revision: D13190: [autopep8] set max line length to 88.

PiRK added a child revision: D13192: test: use f-strings in abc-* tests.Feb 28 2023, 16:02

Harbormaster completed remote builds in B22132: Diff 38105.Feb 28 2023, 16:15

Fabien requested changes to this revision.Feb 28 2023, 16:26

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/feature_minchainwork.py
50 ↗	(On Diff #38105)

This revision now requires changes to proceed.Feb 28 2023, 16:26

review

while I'm doing manual changes, also remove unnecessary str(...) conversions

Harbormaster completed remote builds in B22161: Diff 38154.Mar 1 2023, 07:47

Harbormaster completed remote builds in B22162: Diff 38155.Mar 1 2023, 08:00

Fabien accepted this revision.Mar 1 2023, 08:54

This revision is now accepted and ready to land.Mar 1 2023, 08:54

Closed by commit rABCe3d2ac1fd3e4: test: use f-strings in feature_* tests (part 3, with flynt) (authored by PiRK). · Explain WhyMar 1 2023, 09:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe3d2ac1fd3e4: test: use f-strings in feature_* tests (part 3, with flynt).

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_addrman.py

4 lines

feature_assumevalid.py

4 lines

feature_block.py

13 lines

feature_csv_activation.py

4 lines

feature_dersig.py

2 lines

feature_init.py

4 lines

feature_logging.py

12 lines

feature_minchainwork.py

12 lines

feature_notifications.py

6 lines

14 lines

19 lines

2 lines

14 lines

4 lines

Diff 38154

View Options

test/functional/feature_addrman.py

View Options

test/functional/feature_assumevalid.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_init.py

View Options

test/functional/feature_logging.py

View Options

test/functional/feature_minchainwork.py

View Options

test/functional/feature_notifications.py

View Options

test/functional/feature_proxy.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/feature_settings.py

View Options

test/functional/feature_uaclient.py

View Options

test/functional/feature_uacomment.py

test: use f-strings in feature_* tests (part 3, with flynt)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38154

test/functional/feature_addrman.py

test/functional/feature_assumevalid.py

test/functional/feature_block.py

test/functional/feature_csv_activation.py

test/functional/feature_dersig.py

test/functional/feature_init.py

test/functional/feature_logging.py

test/functional/feature_minchainwork.py

test/functional/feature_notifications.py

test/functional/feature_proxy.py

test/functional/feature_pruning.py

test/functional/feature_settings.py

test/functional/feature_uaclient.py

test/functional/feature_uacomment.py

test: use f-strings in feature_* tests (part 3, with flynt)
ClosedPublic
Actions

Revision Contents
Changeset List