Page MenuHomePhabricator

[alias-server] Accept overpaid tx fees
ClosedPublic

Authored by bytesofman on Feb 28 2023, 23:18.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC33e9b2623426: [alias-server] Accept overpaid tx fees
Summary

T2961

Recognize overpaid registration fees as valid. Bugfix discovered in authoring this diff: txs without OP_RETURN should return false from parseAliasTx

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adding unit test for parseAliasTx patch

Is there a safety net to prevent users from accidentally paying absurdly high fees ?

Is there a safety net to prevent users from accidentally paying absurdly high fees ?

The registration frontend via cashtab uses preset fees depending on the bytes in the alias, so it does not give users the option to set the fee themselves. Technically, any dev can register via custom scripts by sending the fee and the appropriate OP_RETURN script to the payment address, but I don't think we need to hand hold those specific use cases.

This revision is now accepted and ready to land.Mar 1 2023, 12:38

Is there a safety net to prevent users from accidentally paying absurdly high fees ?

The 'official' front ends will create txs with specifically accurate fees. We can't stop people from creating their own txs and sending the wrong amount of money.

The ultimate safety net is the ability to review on a case by case basis and refund. If it is a common problem, we can make it automated --- but this would require a hot wallet.

This revision was automatically updated to reflect the committed changes.