Page MenuHomePhabricator
Differential D13240

Wrap boost::replace_all
ClosedPublic
Actions

Authored by PiRK on Mar 6 2023, 08:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3409b420ba8a: Wrap boost::replace_all
Summary

The included header is thousand lines of template code (not counting the recursive includes) for basically one function.

This is a backport of core#25068

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 6 2023, 08:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2023, 08:57
PiRK requested review of this revision.Mar 6 2023, 08:57
teamcity edited the summary of this revision. (Show Details)Mar 6 2023, 08:57
Harbormaster completed remote builds in B22266: Diff 38306.Mar 6 2023, 09:14
Fabien requested changes to this revision.Mar 6 2023, 12:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
1658 ↗(On Diff #38306)

Macro huhdog:

src/torcontrol.cpp
17 ↗(On Diff #38306)
src/validation.cpp
53 ↗(On Diff #38306)
This revision now requires changes to proceed.Mar 6 2023, 12:31
PiRK updated this revision to Diff 38311.Mar 6 2023, 13:22

address review

Harbormaster completed remote builds in B22271: Diff 38311.Mar 6 2023, 13:39
Fabien accepted this revision.Mar 6 2023, 13:46
This revision is now accepted and ready to land.Mar 6 2023, 13:46
PiRK added inline comments.Mar 6 2023, 13:52
src/init.cpp
1658 ↗(On Diff #38306)

the most reasonable explanation is that I was searching for "HEAD" to solve conflicts, and somehow deleted a search result.

Closed by commit rABC3409b420ba8a: Wrap boost::replace_all (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 6 2023, 14:02
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3409b420ba8a: Wrap boost::replace_all.

Revision Contents
Changeset List

PathSize
src/
1 line
4 lines
4 lines
util/
6 lines
7 lines
4 lines
6 lines
wallet/
6 lines

Diff 38314

View Options

src/CMakeLists.txt

Loading...
View Options

src/init.cpp

Loading...
View Options

src/torcontrol.cpp

Loading...
View Options

src/util/string.h

Loading...
View Options

src/util/string.cpp

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...