Page MenuHomePhabricator

Wrap boost::replace_all
ClosedPublic

Authored by PiRK on Mar 6 2023, 08:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3409b420ba8a: Wrap boost::replace_all
Summary

The included header is thousand lines of template code (not counting the recursive includes) for basically one function.

This is a backport of core#25068

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Mar 6 2023, 08:57
Fabien requested changes to this revision.Mar 6 2023, 12:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
1658

Macro huhdog:

src/torcontrol.cpp
17
src/validation.cpp
53
This revision now requires changes to proceed.Mar 6 2023, 12:31
This revision is now accepted and ready to land.Mar 6 2023, 13:46
src/init.cpp
1658

the most reasonable explanation is that I was searching for "HEAD" to solve conflicts, and somehow deleted a search result.

This revision was automatically updated to reflect the committed changes.