Differential D13289

[Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 11 2023, 08:31.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd30c1e02b6c1: [Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor`

Summary

Allows us to get an ancestor of a &CBlockIndex in Rust.

Depends on D13288.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t chronikbridge_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Mar 11 2023, 08:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 08:31

tobias_ruck requested review of this revision.Mar 11 2023, 08:31

Harbormaster completed remote builds in B22354: Diff 38423.Mar 11 2023, 08:44

tobias_ruck added a child revision: D13290: [Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork`.Mar 11 2023, 09:10

Fabien accepted this revision.Mar 11 2023, 09:34

Fabien added inline comments.

chronik/test/chronikbridge_tests.cpp
99 ↗	(On Diff #38423)	Just use tip->nHeight + 1

This revision is now accepted and ready to land.Mar 11 2023, 09:34

use tip.nHeight + 1

Harbormaster completed remote builds in B22356: Diff 38425.Mar 11 2023, 10:59

Closed by commit rABCd30c1e02b6c1: [Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor` (authored by tobias_ruck). · Explain WhyMar 13 2023, 11:45

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCd30c1e02b6c1: [Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-bridge/

src/

ffi.rs

6 lines

chronik-cpp/

chronik_bridge.h

2 lines

chronik_bridge.cpp

9 lines

test/

chronikbridge_tests.cpp

27 lines

Diff 38486

View Options

chronik/chronik-bridge/src/ffi.rs

View Options

chronik/chronik-cpp/chronik_bridge.h

View Options

chronik/chronik-cpp/chronik_bridge.cpp

View Options

chronik/test/chronikbridge_tests.cpp

[Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38486

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-cpp/chronik_bridge.h

chronik/chronik-cpp/chronik_bridge.cpp

chronik/test/chronikbridge_tests.cpp

[Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor`
ClosedPublic
Actions

Revision Contents
Changeset List