Paths

Table of Contentst

Differential D13291

[Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 11 2023, 12:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCca61d42e085f: [Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex`

Summary

Combined with get_block_info, we can get the same data, but this way, we can get BlockInfo of any CBlockIndex.

Depends on D13290.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t chronikbridge_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Mar 11 2023, 12:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 12:51

tobias_ruck requested review of this revision.Mar 11 2023, 12:51

tobias_ruck edited the summary of this revision. (Show Details)Mar 11 2023, 13:00

tobias_ruck added a parent revision: D13290: [Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork`.

tobias_ruck added a child revision: D13292: [Chronik] Add `get_block_info`.

Harbormaster completed remote builds in B22359: Diff 38428.Mar 11 2023, 13:03

Fabien accepted this revision.Mar 13 2023, 08:51

This revision is now accepted and ready to land.Mar 13 2023, 08:51

Closed by commit rABCca61d42e085f: [Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex` (authored by tobias_ruck). · Explain WhyMar 13 2023, 11:47

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCca61d42e085f: [Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-bridge/

src/

ffi.rs

2 lines

chronik-cpp/

chronik_bridge.h

2 lines

chronik_bridge.cpp

12 lines

test/

chronikbridge_tests.cpp

22 lines

Diff 38488

View Options

chronik/chronik-bridge/src/ffi.rs

View Options

chronik/chronik-cpp/chronik_bridge.h

View Options

chronik/chronik-cpp/chronik_bridge.cpp

View Options

chronik/test/chronikbridge_tests.cpp

[Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38488

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-cpp/chronik_bridge.h

chronik/chronik-cpp/chronik_bridge.cpp

chronik/test/chronikbridge_tests.cpp

[Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex`
ClosedPublic
Actions

Revision Contents
Changeset List