Page MenuHomePhabricator
Differential D13304

[net processing] Remove CNodeState ctor body
ClosedPublic
Actions

Authored by PiRK on Mar 13 2023, 10:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC59c0161152a4: [net processing] Remove CNodeState ctor body
Summary

It's a no-op. The ctor for RollingBloomFilter already calls reset().

This concludes backport of core#21424
https://github.com/bitcoin/bitcoin/pull/21424/commits/55966e0cc03f0e380d21a9434b048d4d515b6729

Depends on D13303

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 13 2023, 10:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 13 2023, 10:24
PiRK requested review of this revision.Mar 13 2023, 10:24
teamcity edited the summary of this revision. (Show Details)Mar 13 2023, 10:24
PiRK retitled this revision from net processing] Remove CNodeState ctor body to [net processing] Remove CNodeState ctor body.Mar 13 2023, 10:25
PiRK added a child revision: D13305: [net processing] Remove unused CNodeState.address member.Mar 13 2023, 10:31
Harbormaster completed remote builds in B22393: Diff 38478.Mar 13 2023, 10:37
Fabien accepted this revision.Mar 13 2023, 11:14
This revision is now accepted and ready to land.Mar 13 2023, 11:14
Closed by commit rABC59c0161152a4: [net processing] Remove CNodeState ctor body (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyMar 13 2023, 12:37
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC59c0161152a4: [net processing] Remove CNodeState ctor body.

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 38500

View Options

src/net_processing.cpp

Loading...