Paths

Table of Contentst

Differential D13313

[alias-server] enforce alphanumeric aliases
ClosedPublic
Actions

Authored by bytesofman on Mar 13 2023, 18:02.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0288d375be11: [alias-server] enforce alphanumeric aliases

Summary

T2987

Add new function isValidAliasString which, for now, rejects any alias containing characters other than lower case a through z or numbers 0 through 9

Test Plan

Review updates to mocks and npm test
Delete old test database and node index.js. Navigate to http://localhost:5000/aliases and no non-alphanumeric aliases

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 13 2023, 18:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 13 2023, 18:02

bytesofman requested review of this revision.Mar 13 2023, 18:02

Harbormaster completed remote builds in B22411: Diff 38514.Mar 13 2023, 18:02

Removing line break

Harbormaster completed remote builds in B22413: Diff 38516.Mar 13 2023, 18:17

emack accepted this revision.Mar 14 2023, 10:38

This revision is now accepted and ready to land.Mar 14 2023, 10:38

Closed by commit rABC0288d375be11: [alias-server] enforce alphanumeric aliases (authored by bytesofman). · Explain WhyMar 14 2023, 11:58

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC0288d375be11: [alias-server] enforce alphanumeric aliases.

Revision Contents
Changeset List

Path

Size

web/

alias-server/

8 lines

test/

55 lines

mocks/

26331 lines

unconfirmedAliasTxs.js

428 lines

13 lines

15 lines

6 lines

Diff 38556

web/alias-server/alias.js

Loading...

web/alias-server/test/alias.js

Loading...

web/alias-server/test/mocks/aliasMocks.js

Loading...

web/alias-server/test/mocks/unconfirmedAliasTxs.js

Loading...

web/alias-server/test/mocks/utilsMocks.js

Loading...

web/alias-server/test/utils.js

Loading...

web/alias-server/utils.js

Loading...