[net processing] Add Orphanage empty consistency check
ClosedPublic
Actions

Authored by PiRK on Mar 17 2023, 15:44.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC6d8a8d911ba6: [net processing] Add Orphanage empty consistency check

Summary

When removing the final peer, assert that m_tx_orphanage is empty.

This is a partial backport of core#21562
https://github.com/bitcoin/bitcoin/pull/21562/commits/9190b01d8dcf03b74e9b9e1653688a97ac171b37

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22521
Build 44662: Build Diff	build-clang-tidy · build-without-wallet · build-clang · build-diff · lint-circular-dependencies · build-debug
Build 44661: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 17 2023, 15:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 15:44

PiRK requested review of this revision.Mar 17 2023, 15:44

teamcity edited the summary of this revision. (Show Details)Mar 17 2023, 15:44

PiRK added a child revision: D13378: [net processing] Default initialize recentRejects.Mar 17 2023, 15:45

Harbormaster completed remote builds in B22521: Diff 38675.Mar 17 2023, 15:57

sdulfari accepted this revision.Mar 17 2023, 19:21

This revision is now accepted and ready to land.Mar 17 2023, 19:21

Closed by commit rABC6d8a8d911ba6: [net processing] Add Orphanage empty consistency check (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyMar 21 2023, 06:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6d8a8d911ba6: [net processing] Add Orphanage empty consistency check.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

1 line

txorphanage.h

6 lines

Diff 38675

View Options

src/net_processing.cpp