Page MenuHomePhabricator
Differential D13418

[tg bot] Add support for XEC price in msgs
AbandonedPublic
Actions

Authored by bytesofman on Mar 21 2023, 22:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

T2972

Depends on D13417

Add support for XEC price in tg msgs. Also add a new test script, npm run price

Test Plan

npm run price all good
npm test
npm run msgs and msgs include price

Diff Detail

Repository
rABC Bitcoin ABC
Branch
new-tg-bot-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22586
Build 44792: Build Diff
Build 44791: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 21 2023, 22:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2023, 22:51
bytesofman requested review of this revision.Mar 21 2023, 22:51
Harbormaster completed remote builds in B22586: Diff 38755.Mar 21 2023, 22:51
bytesofman edited the summary of this revision. (Show Details)Mar 21 2023, 22:52
bytesofman added a parent revision: D13417: [tg bot] Improve msg sending tests.
bytesofman added a child revision: D13419: [tg bot] big etoken tx parsing diff.Mar 22 2023, 00:00
emack added a subscriber: emack.Mar 27 2023, 10:56

coingecko pricing api seems to be timing out (confirmed via cashtab.com). Will test again tomorrow.

Fabien requested changes to this revision.Mar 28 2023, 21:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/ecash-telegram-bot/test/parse.js
41

All these unrelated readability refactors are hiding the actual changes done to the test and should be split apart

This revision now requires changes to proceed.Mar 28 2023, 21:16
bytesofman abandoned this revision.Mar 30 2023, 14:09

Revision Contents
Changeset List

PathSize
web/
ecash-telegram-bot/
5 lines
2 lines
74 lines
4 lines
8 lines
scripts/
18 lines
8 lines
test/
mocks/
21 lines
86 lines
14 lines

Diff 38755

View Options

web/ecash-telegram-bot/chronik.js

Loading...
View Options

web/ecash-telegram-bot/config.js

Loading...
View Options

web/ecash-telegram-bot/package-lock.json

Loading...
View Options

web/ecash-telegram-bot/package.json

Loading...
View Options

web/ecash-telegram-bot/parse.js

Loading...
View Options

web/ecash-telegram-bot/scripts/fetchPrice.js

Loading...
View Options

web/ecash-telegram-bot/scripts/generateMocks.js

Loading...
View Options

web/ecash-telegram-bot/test/mocks/blocks.js

Loading...
View Options

web/ecash-telegram-bot/test/parse.js

Loading...
View Options

web/ecash-telegram-bot/utils.js

Loading...