Page MenuHomePhabricator

[cmake] Fix OSX QT5 support
AbandonedPublic

Authored by schancel on May 1 2018, 16:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title

Test Plan

Run cmake

Diff Detail

Repository
rABC Bitcoin ABC
Branch
osx-cmake-qt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2428
Build 2985: Bitcoin ABC Buildbot (legacy)
Build 2984: arc lint + arc unit

Event Timeline

schancel retitled this revision from [cmake] Fix osx qt5 support to [cmake] Fix OSX QT5 support.May 1 2018, 17:00
deadalnix added inline comments.
src/qt/CMakeLists.txt
10

Why isn't it possible to use components here ?

deadalnix requested changes to this revision.May 1 2018, 22:10
This revision now requires changes to proceed.May 1 2018, 22:10
src/qt/CMakeLists.txt
10

No idea. I don't even know how they work. All I know is the existing stuff doesn't work on MacOS X.

Move include to one function call

deadalnix requested changes to this revision.May 1 2018, 23:26
deadalnix added inline comments.
src/qt/CMakeLists.txt
10 ↗(On Diff #3693)

One way or another, going to the bottom of this will be necessary here.

This revision now requires changes to proceed.May 1 2018, 23:26
src/qt/CMakeLists.txt
10 ↗(On Diff #3693)

This is what their docs say to do for Qt5:

https://doc.qt.io/qt-5.10/cmake-manual.html

Use components because it is imperative that I need to rebase everything again

deadalnix requested changes to this revision.May 2 2018, 21:28
deadalnix added inline comments.
src/qt/CMakeLists.txt
11 ↗(On Diff #3723)

Why do you need to make core explicit ? We never use it directly, so as far as we are concerned, this is Qt's problem to include its own dependencies.

This revision now requires changes to proceed.May 2 2018, 21:28