Page MenuHomePhabricator
Differential D1342

[cmake] Fix OSX QT5 support
AbandonedPublic
Actions

Authored by schancel on May 1 2018, 16:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title

Test Plan

Run cmake

Diff Detail

Event Timeline

schancel created this revision.May 1 2018, 16:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2018, 16:44
teamcity added a subscriber: teamcity.May 1 2018, 16:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel retitled this revision from [cmake] Fix osx qt5 support to [cmake] Fix OSX QT5 support.May 1 2018, 17:00
Harbormaster completed remote builds in B2428: Diff 3669.May 1 2018, 17:10
teamcity added a comment.May 1 2018, 17:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a subscriber: deadalnix.May 1 2018, 20:09
deadalnix added inline comments.
src/qt/CMakeLists.txt
10 ↗(On Diff #3669)

Why isn't it possible to use components here ?

deadalnix requested changes to this revision.May 1 2018, 22:10
This revision now requires changes to proceed.May 1 2018, 22:10
schancel added inline comments.May 1 2018, 22:39
src/qt/CMakeLists.txt
10 ↗(On Diff #3669)

No idea. I don't even know how they work. All I know is the existing stuff doesn't work on MacOS X.

schancel updated this revision to Diff 3692.May 1 2018, 22:41

Move include to one function call

teamcity added a comment.May 1 2018, 22:43

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 3693.May 1 2018, 22:53

Fix CMakeLists.txt

teamcity added a comment.May 1 2018, 22:54

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 1 2018, 23:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2444: Diff 3692.May 1 2018, 23:04
teamcity added a comment.May 1 2018, 23:13

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2445: Diff 3693.May 1 2018, 23:13
deadalnix requested changes to this revision.May 1 2018, 23:26
deadalnix added inline comments.
src/qt/CMakeLists.txt
10 ↗(On Diff #3693)

One way or another, going to the bottom of this will be necessary here.

This revision now requires changes to proceed.May 1 2018, 23:26
schancel added inline comments.May 2 2018, 18:06
src/qt/CMakeLists.txt
10 ↗(On Diff #3693)

This is what their docs say to do for Qt5:

https://doc.qt.io/qt-5.10/cmake-manual.html

schancel added a child revision: D1345: [cmake] support using brew for finding path prefixes on OSX.May 2 2018, 19:06
schancel updated this revision to Diff 3723.May 2 2018, 19:25

Use components because it is imperative that I need to rebase everything again

teamcity added a comment.May 2 2018, 19:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2470: Diff 3723.May 2 2018, 19:45
teamcity added a comment.May 2 2018, 19:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix requested changes to this revision.May 2 2018, 21:28
deadalnix added inline comments.
src/qt/CMakeLists.txt
11 ↗(On Diff #3723)

Why do you need to make core explicit ? We never use it directly, so as far as we are concerned, this is Qt's problem to include its own dependencies.

This revision now requires changes to proceed.May 2 2018, 21:28
schancel updated this revision to Diff 3725.May 2 2018, 21:48

Remove core

teamcity added a comment.May 2 2018, 21:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 22:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 22:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2472: Diff 3725.May 2 2018, 22:23
deadalnix mentioned this in D1377: [cmake] Enable OSX cross compilation.May 6 2018, 01:56
schancel removed a child revision: D1345: [cmake] support using brew for finding path prefixes on OSX.May 6 2018, 05:23
schancel added a child revision: D1345: [cmake] support using brew for finding path prefixes on OSX.May 6 2018, 05:26
schancel removed a child revision: D1345: [cmake] support using brew for finding path prefixes on OSX.May 6 2018, 05:38
schancel added a parent revision: D1345: [cmake] support using brew for finding path prefixes on OSX.
schancel updated this revision to Diff 3795.May 6 2018, 05:39

Rebase

teamcity added a comment.May 6 2018, 05:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2530: Diff 3795.May 6 2018, 06:00
teamcity added a comment.May 6 2018, 06:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel abandoned this revision.May 6 2018, 06:13

Closed in favor of D1377

deadalnix mentioned this in rABCcd0e5a8d43a7: [cmake] Enable OSX cross compilation.May 6 2018, 11:04
schancel removed a parent revision: D1345: [cmake] support using brew for finding path prefixes on OSX.May 8 2018, 00:28
schancel added a child revision: D1345: [cmake] support using brew for finding path prefixes on OSX.May 8 2018, 00:28
deadalnix mentioned this in rSTAGINGcd0e5a8d43a7: [cmake] Enable OSX cross compilation.Sep 27 2018, 18:47

Revision Contents
Changeset List

PathSize
src/
qt/
11 lines

Diff 3725

View Options

src/qt/CMakeLists.txt

Loading...