Page MenuHomePhabricator
Differential D1349

[cmake] move json test generation script out of cmake
ClosedPublic
Actions

Authored by schancel on May 1 2018, 22:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0a4fe4b690e7: [cmake] move json test generation script out of cmake
rABC0a4fe4b690e7: [cmake] move json test generation script out of cmake
Summary

As per title. Previous version used GNU sed specific
features and was broken on MacOS X.

Test Plan

cmake && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.May 1 2018, 22:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2018, 22:36
teamcity added a subscriber: teamcity.May 1 2018, 22:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 1 2018, 22:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2443: Diff 3691!May 1 2018, 22:58
deadalnix requested changes to this revision.May 1 2018, 23:10
deadalnix added a subscriber: deadalnix.

Doing things in a script essentially bypass all search path provided to cmake.

This revision now requires changes to proceed.May 1 2018, 23:10
schancel added a comment.May 2 2018, 02:52
In D1349#26958, @deadalnix wrote:

Doing things in a script essentially bypass all search path provided to cmake.

There are ways to fix this later. In the mean time your use of GNU sed broke everything on every BSD flavor and is unintelligible to read.

schancel updated this revision to Diff 3719.May 2 2018, 18:30

Convert to bad python

teamcity added a comment.May 2 2018, 18:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 18:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2467: Diff 3719.May 2 2018, 18:49
deadalnix accepted this revision.May 2 2018, 21:24
This revision is now accepted and ready to land.May 2 2018, 21:24
deadalnix added inline comments.May 2 2018, 21:25
src/test/CMakeLists.txt
22 ↗(On Diff #3719)

You don't need quotes here.

schancel updated this revision to Diff 3730.May 2 2018, 22:22

Update copywrite

teamcity added a comment.May 2 2018, 22:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Closed by commit rABC0a4fe4b690e7: [cmake] move json test generation script out of cmake (authored by schancel). · Explain WhyMay 2 2018, 22:24
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B2477: Diff 3730.May 2 2018, 22:42
teamcity added a comment.May 2 2018, 22:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Revision Contents
Changeset List

PathSize
src/
test/
28 lines
data/
24 lines

Diff 3731

View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/data/generate_header.py

Loading...