Page MenuHomePhabricator

[cmake] move json test generation script out of cmake
ClosedPublic

Authored by schancel on May 1 2018, 22:36.

Details

Summary

As per title. Previous version used GNU sed specific
features and was broken on MacOS X.

Test Plan

cmake && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
osx-cmake
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2467
Build 3063: Bitcoin ABC Buildbot (legacy)
Build 3062: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.May 1 2018, 23:10
deadalnix added a subscriber: deadalnix.

Doing things in a script essentially bypass all search path provided to cmake.

This revision now requires changes to proceed.May 1 2018, 23:10

Doing things in a script essentially bypass all search path provided to cmake.

There are ways to fix this later. In the mean time your use of GNU sed broke everything on every BSD flavor and is unintelligible to read.

This revision is now accepted and ready to land.May 2 2018, 21:24
src/test/CMakeLists.txt
22

You don't need quotes here.

This revision was automatically updated to reflect the committed changes.