[Chronik] Return `TxNum` from `TxWriter::delete`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 29 2023, 17:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2b5009efd3cb: [Chronik] Return `TxNum` from `TxWriter::delete`

Summary

Subsequent writers, such as GroupHistoryWriter, depends on this, so we return it.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-tx-delete-return-num

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22809
Build 45238: Build Diff	build-chronik
Build 45237: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 29 2023, 17:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2023, 17:58

tobias_ruck requested review of this revision.Mar 29 2023, 17:58

Harbormaster completed remote builds in B22809: Diff 39021.Mar 29 2023, 18:12

Fabien accepted this revision.Mar 29 2023, 19:51

This revision is now accepted and ready to land.Mar 29 2023, 19:51

Closed by commit rABC2b5009efd3cb: [Chronik] Return `TxNum` from `TxWriter::delete` (authored by tobias_ruck). · Explain WhyMar 29 2023, 20:11

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC2b5009efd3cb: [Chronik] Return `TxNum` from `TxWriter::delete`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-db/

src/

io/

txs.rs

12 lines

Diff 39021

View Options

chronik/chronik-db/src/io/txs.rs

[Chronik] Return `TxNum` from `TxWriter::delete`ClosedPublicActions