Page MenuHomePhabricator
Differential D1350

Remove deprecated estimatePriority functionality
ClosedPublic
Actions

Authored by schancel on May 1 2018, 22:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING053945a474ad: Remove deprecated estimatePriority functionality
rABC053945a474ad: Remove deprecated estimatePriority functionality
Summary

As per title

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-priority
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2446
Build 3021: Bitcoin ABC Buildbot (legacy)
Build 3020: arc lint + arc unit

Event Timeline

schancel created this revision.May 1 2018, 22:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2018, 22:58
teamcity added a subscriber: teamcity.May 1 2018, 22:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix requested changes to this revision.May 1 2018, 23:03
deadalnix added a subscriber: deadalnix.

Please add a release note for this. Otherwise, LGTM.

This revision now requires changes to proceed.May 1 2018, 23:03
deadalnix added a comment.May 1 2018, 23:03

Also test plan, make sure you run integration tests.

Harbormaster completed remote builds in B2446: Diff 3694.May 1 2018, 23:16
teamcity added a comment.May 1 2018, 23:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel updated this revision to Diff 3695.May 1 2018, 23:21

Fix fees.h

teamcity added a comment.May 1 2018, 23:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 1 2018, 23:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2447: Diff 3695.May 1 2018, 23:39
schancel updated this revision to Diff 3706.May 2 2018, 03:02

Fix rebase issue on D1357

teamcity added a comment.May 2 2018, 03:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 03:19

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2458: Diff 3706.May 2 2018, 03:19
deadalnix accepted this revision.May 2 2018, 15:12
This revision is now accepted and ready to land.May 2 2018, 15:12
schancel updated this revision to Diff 3713.May 2 2018, 16:49

Rebase

teamcity added a comment.May 2 2018, 16:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 17:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2463: Diff 3713.May 2 2018, 17:14
schancel added a child revision: D1357: Update version number to 0.17.2.May 2 2018, 17:32
schancel removed a child revision: D1357: Update version number to 0.17.2.
schancel added a parent revision: D1357: Update version number to 0.17.2.
Closed by commit rABC053945a474ad: Remove deprecated estimatePriority functionality (authored by schancel). · Explain WhyMay 2 2018, 18:34
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in D1364: [rpc] remove missed rpc parameters.May 3 2018, 03:58
schancel mentioned this in rABC88b5f72133ab: [rpc] remove missed rpc parameters.May 8 2018, 00:02
schancel mentioned this in rSTAGING88b5f72133ab: [rpc] remove missed rpc parameters.Sep 27 2018, 18:47

Revision Contents
Changeset List

PathSize
src/
policy/
4 lines
rpc/
31 lines
3 lines
4 lines

Diff 3694

View Options

src/policy/fees.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...