Differential D13551

scripts: add MACHO tests to test-security-check.py
ClosedPublic
Actions

Authored by PiRK on Apr 4 2023, 09:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8eba6d83b977: scripts: add MACHO tests to test-security-check.py

Summary

This is a backport of core#18415
https://github.com/bitcoin/bitcoin/pull/18415/commits/1a4e9f32efcc5f6a74290446dc58784fd85c7b31

Test Plan

On a MacOS machine, run:

cd contrib/devtools
python3 test-security-check.py

Check that the MacOS specific test passes (the other ones will likely fail due to missing compilers)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22936
Build 45492: Build Diff
Build 45491: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 4 2023, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2023, 09:16

teamcity edited the summary of this revision. (Show Details)Apr 4 2023, 09:16

Harbormaster completed remote builds in B22936: Diff 39195.Apr 4 2023, 09:16

PiRK edited the summary of this revision. (Show Details)Apr 4 2023, 09:17

PiRK published this revision for review.Apr 4 2023, 13:40

PiRK edited the test plan for this revision. (Show Details)

PiRK added a child revision: D13552: scripts: add MACHO NX check to security-check.py.

Fabien accepted this revision.Apr 4 2023, 13:53

This revision is now accepted and ready to land.Apr 4 2023, 13:53

Closed by commit rABC8eba6d83b977: scripts: add MACHO tests to test-security-check.py (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyApr 4 2023, 14:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8eba6d83b977: scripts: add MACHO tests to test-security-check.py.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

test-security-check.py

13 lines

Diff 39195

View Options

contrib/devtools/test-security-check.py

scripts: add MACHO tests to test-security-check.pyClosedPublicActions