Differential D13552

scripts: add MACHO NX check to security-check.py
ClosedPublic
Actions

Authored by PiRK on Apr 4 2023, 09:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC17e9a302df74: scripts: add MACHO NX check to security-check.py

Summary

This is a backport of core#18415
https://github.com/bitcoin/bitcoin/pull/18415/commits/edaca2dd123cef958699c07ab248cf0ffc71af07

Depends on D13551

Test Plan

gitian build and run test-security-check.py on a Mac OS machine

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22937
Build 45494: Build Diff
Build 45493: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 4 2023, 09:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2023, 09:19

teamcity edited the summary of this revision. (Show Details)Apr 4 2023, 09:19

Harbormaster completed remote builds in B22937: Diff 39196.Apr 4 2023, 09:19

@bot gitian-osx

teamcity awarded a token.Apr 4 2023, 09:28

PiRK edited the summary of this revision. (Show Details)Apr 4 2023, 13:41

PiRK added a parent revision: D13551: scripts: add MACHO tests to test-security-check.py.

PiRK removed a parent revision: D13351: [alias-server] rename function getAllAliasTxs to getAliasTxs.

PiRK published this revision for review.Apr 4 2023, 13:43

PiRK edited the test plan for this revision. (Show Details)

Fabien accepted this revision.Apr 4 2023, 13:59

Fabien added a subscriber: Fabien.

Fabien added inline comments.

contrib/devtools/security-check.py
252–254

This revision is now accepted and ready to land.Apr 4 2023, 13:59

Closed by commit rABC17e9a302df74: scripts: add MACHO NX check to security-check.py (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyApr 4 2023, 14:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC17e9a302df74: scripts: add MACHO NX check to security-check.py.

PiRK added a child revision: D13553: scripts: rename test_64bit_PE to test_PE.Apr 4 2023, 15:57

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

security-check.py

11 lines

test-security-check.py

2 lines

Diff 39196

View Options

contrib/devtools/security-check.py