Page MenuHomePhabricator
Differential D1356

[cmake] add functional tests to cmake
ClosedPublic
Actions

Authored by schancel on May 2 2018, 02:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGb79291a69958: [cmake] add functional tests to cmake
rABCb79291a69958: [cmake] add functional tests to cmake
Summary

Setup functional tests under cmake

Test Plan
make check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake-functional
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2505
Build 3134: Bitcoin ABC Buildbot (legacy)
Build 3133: arc lint + arc unit

Event Timeline

schancel created this revision.May 2 2018, 02:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2018, 02:38
teamcity added a subscriber: teamcity.May 2 2018, 02:40

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 02:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2454: Diff 3702.May 2 2018, 02:58
schancel added a subscriber: deadalnix.May 2 2018, 05:40

If it works and its stupid... @deadalnix Have any idea how to do this better?

schancel updated this revision to Diff 3712.May 2 2018, 16:48

Use symlinks

teamcity added a comment.May 2 2018, 16:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 17:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2462: Diff 3712.May 2 2018, 17:09
schancel retitled this revision from [cmake,wip] add functional tests to cmake to [cmake] add functional tests to cmake.May 2 2018, 17:33
deadalnix requested changes to this revision.May 4 2018, 16:24

The CMakeList seems to be doing the right thing overall but in a very confusing way. It's be great to separate what's the config generation from the symlink and test runner definition.

test/CMakeLists.txt
24 ↗(On Diff #3712)

This would probably work better as an add_custom_command , then you can make the test run target directly depends on the files.

49 ↗(On Diff #3712)

This should be declared as a dependency to check-all .

This revision now requires changes to proceed.May 4 2018, 16:24
schancel updated this revision to Diff 3766.May 4 2018, 19:44

Fix commentary from deadalnix

teamcity added a comment.May 4 2018, 21:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 4 2018, 21:46

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2505: Diff 3766!May 4 2018, 21:47
deadalnix accepted this revision.May 7 2018, 02:31
This revision is now accepted and ready to land.May 7 2018, 02:31
Closed by commit rABCb79291a69958: [cmake] add functional tests to cmake (authored by schancel). · Explain WhyMay 7 2018, 20:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
test/
63 lines

Diff 3766

View Options

CMakeLists.txt

Loading...
View Options

test/CMakeLists.txt

Loading...