Page MenuHomePhabricator

[cmake] add functional tests to cmake
ClosedPublic

Authored by schancel on May 2 2018, 02:38.

Details

Summary

Setup functional tests under cmake

Test Plan
make check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake-functional
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2505
Build 3134: Bitcoin ABC Buildbot (legacy)
Build 3133: arc lint + arc unit

Event Timeline

If it works and its stupid... @deadalnix Have any idea how to do this better?

schancel retitled this revision from [cmake,wip] add functional tests to cmake to [cmake] add functional tests to cmake.May 2 2018, 17:33
deadalnix requested changes to this revision.May 4 2018, 16:24

The CMakeList seems to be doing the right thing overall but in a very confusing way. It's be great to separate what's the config generation from the symlink and test runner definition.

test/CMakeLists.txt
24 ↗(On Diff #3712)

This would probably work better as an add_custom_command , then you can make the test run target directly depends on the files.

49 ↗(On Diff #3712)

This should be declared as a dependency to check-all .

This revision now requires changes to proceed.May 4 2018, 16:24

Fix commentary from deadalnix

This revision is now accepted and ready to land.May 7 2018, 02:31
This revision was automatically updated to reflect the committed changes.