Page MenuHomePhabricator
Differential D13607

[alias-server] match output scripts for p2pkh or p2sh registration address
ClosedPublic
Actions

Authored by bytesofman on Apr 6 2023, 18:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC375634ca7bc2: [alias-server] match output scripts for p2pkh or p2sh registration address
Summary

T3060

Depends on D13606

Remove hard-coded outputScript matcher used to parse valid alias txs.

Add unit tested function to get the desired outputScript from address.

Modify calls to functions with modified params.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 6 2023, 18:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2023, 18:15
bytesofman requested review of this revision.Apr 6 2023, 18:15
Harbormaster completed remote builds in B23052: Diff 39368.Apr 6 2023, 18:16
bytesofman updated this revision to Diff 39369.Apr 6 2023, 18:16

Remove now-unused hash160 param

Harbormaster completed remote builds in B23053: Diff 39369.Apr 6 2023, 18:17
bytesofman updated this revision to Diff 39370.Apr 6 2023, 18:18

undo order change in config.js

Harbormaster completed remote builds in B23054: Diff 39370.Apr 6 2023, 18:19
Fabien mentioned this in D13604: [alias-server] Use address as parameter instead of hardcoded p2pkh and hash parameter.Apr 7 2023, 08:26
Fabien requested changes to this revision.Apr 7 2023, 08:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/src/alias.js
99 ↗(On Diff #39370)

That's no longer what this is doing, it can be p2sh

This revision now requires changes to proceed.Apr 7 2023, 08:35
bytesofman updated this revision to Diff 39394.Apr 7 2023, 13:41

remove p2pkh specific comments

Harbormaster completed remote builds in B23074: Diff 39394.Apr 7 2023, 13:42
Fabien accepted this revision.Apr 7 2023, 14:24
This revision is now accepted and ready to land.Apr 7 2023, 14:24
Closed by commit rABC375634ca7bc2: [alias-server] match output scripts for p2pkh or p2sh registration address (authored by bytesofman). · Explain WhyApr 7 2023, 15:07
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC375634ca7bc2: [alias-server] match output scripts for p2pkh or p2sh registration address.

Revision Contents
Changeset List

PathSize
apps/
alias-server/
1 line
src/
19 lines
11 lines
test/
17 lines
mocks/
1 line
18 lines

Diff 39399

View Options

apps/alias-server/config.js

Loading...
View Options

apps/alias-server/src/alias.js

Loading...
View Options

apps/alias-server/src/utils.js

Loading...
View Options

apps/alias-server/test/aliasTests.js

Loading...
View Options

apps/alias-server/test/mocks/chronikMock.js

Loading...
View Options

apps/alias-server/test/utilsTests.js

Loading...