Page MenuHomePhabricator
Differential D13604

[alias-server] Use address as parameter instead of hardcoded p2pkh and hash parameter
ClosedPublic
Actions

Authored by bytesofman on Apr 6 2023, 17:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC77d617aa366d: [alias-server] Use address as parameter instead of hardcoded p2pkh and hash…
Summary

T3060

We want the server to work with any arbitrary registration address, be it p2pkh or p2sh. Refactor to remove hardcoded instances of p2pkh.

Add unit test for this change in initializeWebsocket function.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 6 2023, 17:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2023, 17:21
bytesofman requested review of this revision.Apr 6 2023, 17:21
Harbormaster completed remote builds in B23044: Diff 39358.Apr 6 2023, 17:25
bytesofman updated this revision to Diff 39359.Apr 6 2023, 17:26

removing unrelated changes to chronik mock

Harbormaster completed remote builds in B23045: Diff 39359.Apr 6 2023, 17:27
bytesofman updated this revision to Diff 39362.Apr 6 2023, 17:29

add unit test for p2sh websocket initialization

Harbormaster completed remote builds in B23046: Diff 39362.Apr 6 2023, 17:29
bytesofman updated this revision to Diff 39363.Apr 6 2023, 17:30

linting

bytesofman updated this revision to Diff 39364.Apr 6 2023, 17:33

Updating comments about chronik mock

Harbormaster completed remote builds in B23048: Diff 39364.Apr 6 2023, 17:45
Harbormaster completed remote builds in B23047: Diff 39363.
bytesofman added a child revision: D13605: [alias-server] Improve mocked chronik class.Apr 6 2023, 17:49
Fabien requested changes to this revision.Apr 7 2023, 08:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/config.js
20 ↗(On Diff #39364)

If it's no longer used it should be removed

This revision now requires changes to proceed.Apr 7 2023, 08:16
Fabien accepted this revision.Apr 7 2023, 08:26
Fabien added inline comments.
apps/alias-server/config.js
20 ↗(On Diff #39364)

OK I see it's still used and removed in D13607

This revision is now accepted and ready to land.Apr 7 2023, 08:26
Closed by commit rABC77d617aa366d: [alias-server] Use address as parameter instead of hardcoded p2pkh and hash… (authored by bytesofman). · Explain WhyApr 7 2023, 15:06
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC77d617aa366d: [alias-server] Use address as parameter instead of hardcoded p2pkh and hash….

Revision Contents
Changeset List

PathSize
apps/
alias-server/
2 lines
scripts/
2 lines
src/
32 lines
2 lines
14 lines
test/
44 lines
mocks/
30 lines
50 lines

Diff 39396

View Options

apps/alias-server/config.js

Loading...
View Options

apps/alias-server/scripts/generateMocks.js

Loading...
View Options

apps/alias-server/src/chronik.js

Loading...
View Options

apps/alias-server/src/utils.js

Loading...
View Options

apps/alias-server/src/websocket.js

Loading...
View Options

apps/alias-server/test/chronikTests.js

Loading...
View Options

apps/alias-server/test/mocks/chronikMock.js

Loading...
View Options

apps/alias-server/test/websocketTests.js

Loading...