Page MenuHomePhabricator

[alias-server] Use address as parameter instead of hardcoded p2pkh and hash parameter
ClosedPublic

Authored by bytesofman on Apr 6 2023, 17:21.

Details

Summary

T3060

We want the server to work with any arbitrary registration address, be it p2pkh or p2sh. Refactor to remove hardcoded instances of p2pkh.

Add unit test for this change in initializeWebsocket function.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-functions-address-input
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23044
Build 45708: Build Diffalias-server-tests
Build 45707: arc lint + arc unit

Event Timeline

removing unrelated changes to chronik mock

add unit test for p2sh websocket initialization

Updating comments about chronik mock

Fabien requested changes to this revision.Apr 7 2023, 08:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/config.js
20 ↗(On Diff #39364)

If it's no longer used it should be removed

This revision now requires changes to proceed.Apr 7 2023, 08:16
Fabien added inline comments.
apps/alias-server/config.js
20 ↗(On Diff #39364)

OK I see it's still used and removed in D13607

This revision is now accepted and ready to land.Apr 7 2023, 08:26