Page MenuHomePhabricator

[tg bot] Unit test for main()
ClosedPublic

Authored by bytesofman on Apr 7 2023, 18:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9785bd8e9d4e: [tg bot] Unit test for main()
Summary

T2972

Depends on D13617

Unit test app starting function, main. chronikMock.js is improved to return more realistic websocket info.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/index.js
14 ↗(On Diff #39411)

unrelated: doesn't channelId belong to the telegramBot ? Same question for the address and chronik

apps/ecash-herald/src/main.js
46 ↗(On Diff #39411)

you just failed to initialize your tg bot, I can't really imagine that you would be able to send a message even via another channel

This revision is now accepted and ready to land.Apr 9 2023, 06:50
This revision was automatically updated to reflect the committed changes.