Page MenuHomePhabricator
Differential D13620

[herald] function to handle block connected msg
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 18:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa1c0af9ef710: [herald] function to handle block connected msg
Summary

T2972

Depends on D13619

Move logic to handle BlockConnected msg to its own function. Add unit tests for failure and backup tg msgs.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 7 2023, 18:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 18:42
bytesofman requested review of this revision.Apr 7 2023, 18:42
Harbormaster completed remote builds in B23088: Diff 39413.Apr 7 2023, 18:43
bytesofman added a child revision: D13622: [herald] Refactor handleBlockConnected to support multiple api calls later.Apr 7 2023, 21:38
Fabien accepted this revision.Apr 9 2023, 06:53
This revision is now accepted and ready to land.Apr 9 2023, 06:53
Fabien requested changes to this revision.Apr 9 2023, 06:57
Fabien added inline comments.
apps/ecash-herald/src/events.js
41 ↗(On Diff #39413)

return await ...

53 ↗(On Diff #39413)

default to return false

apps/ecash-herald/test/eventsTests.js
94 ↗(On Diff #39413)

Also check the case where it returns false

This revision now requires changes to proceed.Apr 9 2023, 06:57
bytesofman updated this revision to Diff 39484.Apr 10 2023, 16:00

Add case for sendMessage error, feedback response

Harbormaster completed remote builds in B23149: Diff 39484.Apr 10 2023, 16:00
bytesofman updated this revision to Diff 39485.Apr 10 2023, 16:12

responding to feedback

Harbormaster completed remote builds in B23150: Diff 39485.Apr 10 2023, 16:12
bytesofman updated this revision to Diff 39496.Apr 10 2023, 16:31

rebase

Harbormaster completed remote builds in B23161: Diff 39496.Apr 10 2023, 16:31
Fabien accepted this revision.Apr 10 2023, 18:54
Fabien added inline comments.
apps/ecash-herald/test/eventsTests.js
124 ↗(On Diff #39496)

Same remark as D13617, this assert is useless and should be removed

This revision is now accepted and ready to land.Apr 10 2023, 18:54
Closed by commit rABCa1c0af9ef710: [herald] function to handle block connected msg (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCa1c0af9ef710: [herald] function to handle block connected msg.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
53 lines
49 lines
test/
130 lines

Diff 39609

View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/src/websocket.js

Loading...
View Options

apps/ecash-herald/test/eventsTests.js

Loading...