Page MenuHomePhabricator
Differential D1363

[rpc] remove estimatesmartfee api
ClosedPublic
Actions

Authored by schancel on May 3 2018, 03:40.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING857f0a2a01f9: [rpc] remove estimatesmartfee api
rABC857f0a2a01f9: [rpc] remove estimatesmartfee api
Summary

Remove estimatesmartfee API. It isn't particularly smart.
estimatefee is a suitable replacement for the time being.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-smartfee
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2524
Build 3168: Bitcoin ABC Buildbot (legacy)
Build 3167: arc lint + arc unit

Event Timeline

schancel created this revision.May 3 2018, 03:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2018, 03:40
teamcity added a subscriber: teamcity.May 3 2018, 03:40

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 3 2018, 03:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 3748.May 3 2018, 03:59

Update release notes as well

teamcity added a comment.May 3 2018, 04:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 3 2018, 04:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2486: Diff 3746.May 3 2018, 04:23
Harbormaster completed remote builds in B2488: Diff 3748.
teamcity added a comment.May 3 2018, 04:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox requested changes to this revision.May 3 2018, 21:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
doc/release-notes.md
8 ↗(On Diff #3748)

Remote -> Remove

src/rpc/mining.cpp
963 ↗(On Diff #3748)

Does mempool.estimateSmartFee have other dependents that prevents you from removing it in this diff? If not, please remove it. :)

This revision now requires changes to proceed.May 3 2018, 21:18
schancel added inline comments.May 6 2018, 04:52
src/rpc/mining.cpp
963 ↗(On Diff #3748)

It has quite a few others. I need to do quite a lot of work to remove it completely. First step is removing the RPC layer though. It's pretty embedded in the wallet.

schancel updated this revision to Diff 3789.May 6 2018, 04:52

Fix remote -> remove

teamcity added a comment.May 6 2018, 04:54

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 6 2018, 04:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2524: Diff 3789!May 6 2018, 04:55
jasonbcox accepted this revision.May 6 2018, 17:54
This revision is now accepted and ready to land.May 6 2018, 17:54
Closed by commit rABC857f0a2a01f9: [rpc] remove estimatesmartfee api (authored by schancel). · Explain WhyMay 8 2018, 00:08
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in D1386: [qa] remove now-broken `smartfees.py` test.May 8 2018, 22:26
schancel mentioned this in rABC62a8db68373b: [qa] remove now-broken `smartfees.py` test.May 9 2018, 07:03
schancel mentioned this in rSTAGING62a8db68373b: [qa] remove now-broken `smartfees.py` test.Sep 27 2018, 18:47

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
rpc/
1 line
46 lines

Diff 3789

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...