Page MenuHomePhabricator

[rpc] remove estimatesmartfee api
ClosedPublic

Authored by schancel on May 3 2018, 03:40.

Details

Summary

Remove estimatesmartfee API. It isn't particularly smart.
estimatefee is a suitable replacement for the time being.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-smartfee
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2524
Build 3168: Bitcoin ABC Buildbot (legacy)
Build 3167: arc lint + arc unit

Event Timeline

Update release notes as well

jasonbcox requested changes to this revision.May 3 2018, 21:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
doc/release-notes.md
8 ↗(On Diff #3748)

Remote -> Remove

src/rpc/mining.cpp
963 ↗(On Diff #3748)

Does mempool.estimateSmartFee have other dependents that prevents you from removing it in this diff? If not, please remove it. :)

This revision now requires changes to proceed.May 3 2018, 21:18
src/rpc/mining.cpp
963 ↗(On Diff #3748)

It has quite a few others. I need to do quite a lot of work to remove it completely. First step is removing the RPC layer though. It's pretty embedded in the wallet.

This revision is now accepted and ready to land.May 6 2018, 17:54
This revision was automatically updated to reflect the committed changes.