Page MenuHomePhabricator

[rpc] remove missed rpc parameters
ClosedPublic

Authored by schancel on May 3 2018, 03:58.

Details

Summary

Clean up RPC parameter mapping for estimatesmartpriority and estimatepriority,
which were removed in D1353 and D1350.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clean-rpc-params
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2487
Build 3103: Bitcoin ABC Buildbot (legacy)
Build 3102: arc lint + arc unit

Event Timeline

jasonbcox added inline comments.
src/rpc/client.cpp
107

Is it possible to write a test that detects RPC params in this list that do not have an implementation? That way, we don't have to worry about this in the future.

deadalnix added inline comments.
src/rpc/client.cpp
107

startrekagree

Or even better, have a way to specify this with the RPC call, not is some 3rd party data-structure.

src/rpc/client.cpp
107

I will look into it as soon as I get the fees stuff working. This can sit until then.

deadalnix added inline comments.
src/rpc/client.cpp
107

I trust you. Please make sure you make a task for it, we know this is tech debt that needs to be cleaned up.

This revision is now accepted and ready to land.May 6 2018, 22:56
This revision was automatically updated to reflect the committed changes.