Paths

Table of Contentst

Differential D13715

[herald] Remove unnecessary flag variable
ClosedPublic
Actions

Authored by bytesofman on Apr 14 2023, 03:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCef0b2718d18b: [herald] Remove unnecessary flag variable

Summary

T2972

Depends on D13714

No need for isGenesisTx as genesisInfo does the same thing

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tg-function-to-utils

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23307
Build 46233: Build Diff	ecash-herald-tests
Build 46232: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 14 2023, 03:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2023, 03:32

bytesofman requested review of this revision.Apr 14 2023, 03:32

Harbormaster completed remote builds in B23307: Diff 39721.Apr 14 2023, 03:34

bytesofman added a child revision: D13716: [herald] Remove unused flag from `parsedTx` data.Apr 14 2023, 03:36

Fabien accepted this revision.Apr 14 2023, 13:24

This revision is now accepted and ready to land.Apr 14 2023, 13:24

Closed by commit rABCef0b2718d18b: [herald] Remove unnecessary flag variable (authored by bytesofman). · Explain WhyApr 14 2023, 21:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCef0b2718d18b: [herald] Remove unnecessary flag variable.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

11 lines

test/

mocks/

blocks.js

Diff 39721

View Options

apps/ecash-herald/src/parse.js