Page MenuHomePhabricator
Differential D1373

Update NSIS icons and imagery
ClosedPublic
Actions

Authored by movrcx on May 4 2018, 19:03.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGING48f33b511ae1: Update NSIS icons and imagery
rABC48f33b511ae1: Update NSIS icons and imagery
Summary

Changes Bitcoin Core logos to Bitcoin-abc and Bitcoin Cash

Test Plan

make deploy, attach screenshots

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

movrcx created this revision.May 4 2018, 19:03
Owners added a reviewer: Restricted Owners Package.May 4 2018, 19:03
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMay 4 2018, 19:03
movrcx added a child revision: D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.May 4 2018, 19:04
movrcx added a comment.May 4 2018, 19:34

This diff updates the NSIS icons and imagery only. See D1370 for installation directory and uninstall registry key changes.

b5.PNG (582×852 px, 33 KB)

b4.PNG (582×852 px, 27 KB)

b3.PNG (388×499 px, 22 KB)

b2.PNG (388×499 px, 15 KB)

b1.PNG (388×499 px, 21 KB)

movrcx mentioned this in D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.May 4 2018, 19:47
teamcity added a subscriber: teamcity.May 4 2018, 21:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2504: Diff 3765!May 4 2018, 21:46
teamcity added a comment.May 4 2018, 21:46

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

deadalnix added a subscriber: deadalnix.May 6 2018, 11:11

Where does bitcoin256.png comes from ? The edges are all fubared.

movrcx added a comment.May 7 2018, 15:19
In D1373#27860, @deadalnix wrote:

Where does bitcoin256.png comes from ? The edges are all fubared.

It comes from https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/qt/res/icons/bitcoin.png and all of the icons were ran through https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/contrib/devtools/optimize-pngs.py before upload.

schancel accepted this revision.May 14 2018, 22:59
schancel added a subscriber: schancel.

I'm good with this change, it might be nice to rename the files to indicate that they are not bitcoin logos anymore.

This revision is now accepted and ready to land.May 14 2018, 22:59
teamcity added a comment.May 14 2018, 22:59

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 14 2018, 23:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2504: Diff 3765!May 14 2018, 23:01
movrcx updated this revision to Diff 3972.May 24 2018, 18:08

Recreate icons based off of original vector file

teamcity added a comment.May 24 2018, 18:08

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 24 2018, 18:09

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2639: Diff 3972!May 24 2018, 18:09
deadalnix accepted this revision.May 25 2018, 14:37
Closed by commit rABC48f33b511ae1: Update NSIS icons and imagery (authored by movrcx). · Explain WhyMay 25 2018, 14:42
This revision was automatically updated to reflect the committed changes.
movrcx removed a child revision: D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.Sep 25 2018, 07:13

Revision Contents
Changeset List

Diff 3991

View Options

share/pixmaps/bitcoin.ico

Loading...
View Options

share/pixmaps/bitcoin128.png

Loading...
View Options

share/pixmaps/bitcoin128.xpm

Loading...
View Options

share/pixmaps/bitcoin16.png

Loading...
View Options

share/pixmaps/bitcoin16.xpm

Loading...
View Options

share/pixmaps/bitcoin256.png

Loading...
View Options

share/pixmaps/bitcoin256.xpm

Loading...
View Options

share/pixmaps/bitcoin32.png

Loading...
View Options

share/pixmaps/bitcoin32.xpm

Loading...
View Options

share/pixmaps/bitcoin64.png

Loading...
View Options

share/pixmaps/bitcoin64.xpm

Loading...
View Options

share/pixmaps/nsis-header.bmp

Loading...
View Options

share/pixmaps/nsis-wizard.bmp

Loading...