Page MenuHomePhabricator

movrcx (Joshua Yabut)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2018, 00:30 (94 w, 6 d)

Recent Activity

Oct 9 2018

movrcx committed rSTAGINGa5d17df3b034: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core… (authored by movrcx).
Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core…
Oct 9 2018, 20:58

Oct 4 2018

movrcx abandoned D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

No longer needed.

Oct 4 2018, 17:17
movrcx committed rABCa5d17df3b034: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core… (authored by movrcx).
Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core…
Oct 4 2018, 16:15
movrcx closed D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.
Oct 4 2018, 16:15

Sep 27 2018

movrcx committed rSTAGING48f33b511ae1: Update NSIS icons and imagery (authored by movrcx).
Update NSIS icons and imagery
Sep 27 2018, 18:50
movrcx committed rSTAGINGc075107209fa: Backport build-windows.md from Core repository (authored by movrcx).
Backport build-windows.md from Core repository
Sep 27 2018, 18:50
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase

Sep 27 2018, 17:26
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase

Sep 27 2018, 17:21
movrcx updated the diff for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

Rebase

Sep 27 2018, 17:18
movrcx updated the diff for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

Rebase

Sep 27 2018, 17:16
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase

Sep 27 2018, 17:11
movrcx updated the diff for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

test

Sep 27 2018, 16:17
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase

Sep 27 2018, 11:31
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase

Sep 27 2018, 11:24

Sep 26 2018

movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

test

Sep 26 2018, 21:21
movrcx changed the repository for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC from rABC Bitcoin ABC to rSTAGING Bitcoin ABC staging.
Sep 26 2018, 18:44
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

another fixup attempt

Sep 26 2018, 15:25
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Cleanup and rebase

Sep 26 2018, 02:30
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Another rebase attempt

Sep 26 2018, 01:56
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

test

Sep 26 2018, 01:40
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

testing

Sep 26 2018, 01:34
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase attempt

Sep 26 2018, 01:31
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Move to new task

Sep 26 2018, 01:20
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

ci fix

Sep 26 2018, 01:18
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

staging test

Sep 26 2018, 01:16
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Staging test

Sep 26 2018, 01:11
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

rebase test

Sep 26 2018, 00:55
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Staging area testing

Sep 26 2018, 00:50
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Restore file permissions on nsis .bmp's

Sep 26 2018, 00:22
movrcx added a comment to D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

I've got this built locally and running (see below) using a linux cross-compile. I need to figure out why it's not building on the CI. Pictures below:

Sep 26 2018, 00:00

Sep 25 2018

movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Remove accidentally merged commit per @jasonbcox

Sep 25 2018, 23:56
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Build fix

Sep 25 2018, 07:11
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase to master

Sep 25 2018, 07:04
movrcx added a comment to D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

I've got this built locally and running (see below) using a linux cross-compile. I need to figure out why it's not building on the CI. Pictures below:

Sep 25 2018, 06:57
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase fix 2

Sep 25 2018, 02:46
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebase fix

Sep 25 2018, 02:39
movrcx updated the diff for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

Update staging

Sep 25 2018, 01:09

Sep 20 2018

movrcx updated the diff for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

Rebase off fresh master.

Sep 20 2018, 23:48

Sep 17 2018

movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Rebased from D1787

Sep 17 2018, 18:22

May 25 2018

movrcx committed rABCc075107209fa: Backport build-windows.md from Core repository (authored by movrcx).
Backport build-windows.md from Core repository
May 25 2018, 14:43
movrcx closed D1415: Backport build-windows.md from Core repository.
May 25 2018, 14:42
movrcx committed rABC48f33b511ae1: Update NSIS icons and imagery (authored by movrcx).
Update NSIS icons and imagery
May 25 2018, 14:42
movrcx closed D1373: Update NSIS icons and imagery.
May 25 2018, 14:42

May 24 2018

movrcx updated the diff for D1373: Update NSIS icons and imagery.

Recreate icons based off of original vector file

May 24 2018, 18:08

May 17 2018

movrcx accepted D1428: [qa] bump test timeout when running on the build system.

Looks good to me.

May 17 2018, 15:54

May 15 2018

Herald added a reviewer for D1415: Backport build-windows.md from Core repository: Restricted Project.
May 15 2018, 02:51
movrcx added a comment to T336: Phabricator to Github repo sync bot.

This might be able to be configured through a Phabricator setting:

May 15 2018, 00:57

May 7 2018

movrcx added inline comments to D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.
May 7 2018, 18:31
movrcx updated the test plan for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.
May 7 2018, 17:40
movrcx updated the diff for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions

May 7 2018, 17:39
movrcx added a comment to D1373: Update NSIS icons and imagery.

Where does bitcoin256.png comes from ? The edges are all fubared.

May 7 2018, 15:19

May 4 2018

movrcx added a comment to D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

This is still a WIP, going to make this an independent function and add tests...

May 4 2018, 20:23
movrcx updated the summary of D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.
May 4 2018, 20:05
movrcx added a comment to D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Screenshots from 05903a903976

May 4 2018, 20:03
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Split image edits into D1373 (removes test_main.cpp which kept sneaking in the previous commits)

May 4 2018, 19:51
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Split image edits into D1373 (last commit had an error)

May 4 2018, 19:49
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Split image edits into D1373

May 4 2018, 19:47
movrcx added a comment to D1373: Update NSIS icons and imagery.

This diff updates the NSIS icons and imagery only. See D1370 for installation directory and uninstall registry key changes.

May 4 2018, 19:34
Herald added 1 blocking reviewer(s) for D1373: Update NSIS icons and imagery: Restricted Project.
May 4 2018, 19:03
movrcx added a comment to D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

You made all the images executable. Thanks for the screenshots, it looks great!
It would also be preferable to do the renaming and the images change in two different diffs as I makes review impossible.

May 4 2018, 18:33
movrcx retitled D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC from Update NSIS icons and imagery from Bitcoin Core to Bitcoin ABC to Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.
May 4 2018, 18:18
movrcx added a comment to D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Screenshots from 1af0c431211c448724e943e2a629d98fbbd3eaab

May 4 2018, 18:17
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Squash previous two commits

May 4 2018, 18:16
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Update installation directory, installation registry key, and filenames

May 4 2018, 18:12
movrcx added a comment to D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Images from updated installer:

May 4 2018, 17:28
movrcx updated the test plan for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.
May 4 2018, 17:13
movrcx updated the diff for D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.

Remove Gimp metadata from .xpm files

May 4 2018, 17:05
movrcx created D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.
May 4 2018, 16:31
movrcx added a comment to D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions.

Googleing a bit, it seems like setenv doesn't exist on windows. So:

  • There is no way to to know if the fix is appropriate with knowing what the problem is.
  • If the problem is that there is no way to set environment variable in a plateform agnostic manner, and we want one, then we make one.
  • In the absence of the above mentionned way, it is only a matter of time before this breaks again.
  • It doesn't seem to be the responsibility of the main function to know about the management of environment variable on various systems so it seems inappropriate to put it there.
  • It doesn't looks like the cross compilation has been tested in any way. I suspect it may not be working at all.
May 4 2018, 15:36

May 3 2018

Herald added 1 blocking reviewer(s) for D1368: Add platform-independent SetEnvironmentalVariable() and GetEnvironmentalVariable() functions: Restricted Project.
May 3 2018, 18:12

Mar 30 2018

movrcx updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

Update comment in monolith-opcodes.py

Mar 30 2018, 22:19
movrcx added a comment to D1194: Set Monolith opcode enable script flag if monolith enabled.
user@debian:~/code/bitcoin-abc$ test/functional/test_runner.py 
ALL                              | ✓ Passed  | 480 s (accumulated) 
...
Runtime: 127 s
Mar 30 2018, 22:07
movrcx updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

Remove whitespace nits.

Mar 30 2018, 22:00
movrcx updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

Rebased to fresh master.

Mar 30 2018, 21:56

Mar 29 2018

movrcx added inline comments to D1194: Set Monolith opcode enable script flag if monolith enabled.
Mar 29 2018, 19:30
movrcx added inline comments to D1194: Set Monolith opcode enable script flag if monolith enabled.
Mar 29 2018, 19:26
movrcx updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

Major code rebase

Mar 29 2018, 19:14
movrcx added inline comments to D1194: Set Monolith opcode enable script flag if monolith enabled.
Mar 29 2018, 02:00

Mar 28 2018

movrcx removed a revision from T310: Adds OP_NUM2BIN functionality into interpreter.cpp: D1212: Add support for DIV and MOD opcodes.
Mar 28 2018, 19:02
movrcx removed a task from D1212: Add support for DIV and MOD opcodes: T310: Adds OP_NUM2BIN functionality into interpreter.cpp.
Mar 28 2018, 19:02
movrcx added a revision to T310: Adds OP_NUM2BIN functionality into interpreter.cpp: D1212: Add support for DIV and MOD opcodes.
Mar 28 2018, 19:01
movrcx added a task to D1212: Add support for DIV and MOD opcodes: T310: Adds OP_NUM2BIN functionality into interpreter.cpp.
Mar 28 2018, 19:01
movrcx updated the diff for D1212: Add support for DIV and MOD opcodes.

Fixup: Minor typo in modulus error message

Mar 28 2018, 18:29
movrcx updated the diff for D1212: Add support for DIV and MOD opcodes.
Mar 28 2018, 18:27

Mar 17 2018

movrcx updated the diff for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

Rebase off of master

Mar 17 2018, 02:21
movrcx updated the diff for D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.

Rebase off of master

Mar 17 2018, 02:20
movrcx updated the diff for D1099: Adds OP_SPLIT functionality into interpreter.cpp.

Rebase off of master

Mar 17 2018, 02:19
movrcx updated the diff for D1097: Add support for CAT, and SPLIT opcodes.

Rebase off of master

Mar 17 2018, 02:18
movrcx updated the diff for D1095: Adds OP_MOD functionality into interpreter.cpp.

Rebase off master

Mar 17 2018, 02:17
movrcx updated the diff for D1093: Adds OP_DIV functionality into interpreter.cpp.

Rebase off master

Mar 17 2018, 02:16
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Rebased off master

Mar 17 2018, 02:14
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Undo previous diff

Mar 17 2018, 02:13
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Adjust input order

Mar 17 2018, 01:23
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Rebase off phabricator master

Mar 17 2018, 01:21
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Fixup for opcode input order

Mar 17 2018, 01:09
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Add script json tests

Mar 17 2018, 00:41

Mar 16 2018

movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Fixup for diff 5 (wrong commit submitted)

Mar 16 2018, 17:06
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Fix monolith_opcodes.cpp for disabled opcodes

Mar 16 2018, 16:53
movrcx updated the diff for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

Cleaning up due to D1202

Mar 16 2018, 03:03
movrcx updated the diff for D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.

Cleaning up due to D1202

Mar 16 2018, 02:57